linux-kernel - Re: [PATCH v2 2/3] dt-bindings: leds: is31fl32xx: convert the binding to yaml

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20250630221906.GA3536184-robh@kernel.org>
Date: Mon, 30 Jun 2025 17:19:06 -0500
From: Rob Herring <robh@...nel.org>
To: Pawel Zalewski <pzalewski@...goodpenguin.co.uk>
Cc: Lee Jones <lee@...nel.org>, Pavel Machek <pavel@...nel.org>,
	Krzysztof Kozlowski <krzk+dt@...nel.org>,
	Conor Dooley <conor+dt@...nel.org>, linux-leds@...r.kernel.org,
	linux-kernel@...r.kernel.org, Pavel Machek <pavel@....cz>,
	devicetree@...r.kernel.org,
	Lucca Fachinetti <luccafachinetti@...il.com>
Subject: Re: [PATCH v2 2/3] dt-bindings: leds: is31fl32xx: convert the
 binding to yaml

On Fri, Jun 27, 2025 at 11:20:36AM +0100, Pawel Zalewski wrote:
> From: Lucca Fachinetti <luccafachinetti@...il.com>
> 
> Keep the old maintainers field as is.
> Add datasheets for reference, NB that I was not able to find an
> up-to-date, funtional direct URL for si-en products datasheet
> so they were skipped.
> 
> Co-developed-by: Pawel Zalewski <pzalewski@...goodpenguin.co.uk>
> Signed-off-by: Pawel Zalewski <pzalewski@...goodpenguin.co.uk>

As the sender of the patches, your tags go last.

> Signed-off-by: Lucca Fachinetti <luccafachinetti@...il.com>
> ---
>  .../devicetree/bindings/leds/leds-is31fl3236.yaml  | 101 +++++++++++++++++++++
>  .../devicetree/bindings/leds/leds-is31fl32xx.txt   |  52 -----------
>  2 files changed, 101 insertions(+), 52 deletions(-)
> 
> diff --git a/Documentation/devicetree/bindings/leds/leds-is31fl3236.yaml b/Documentation/devicetree/bindings/leds/leds-is31fl3236.yaml
> new file mode 100644
> index 0000000000000000000000000000000000000000..f26340850647d1c642fb345b7cf90764200e13ee
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/leds/leds-is31fl3236.yaml
> @@ -0,0 +1,101 @@
> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/leds/leds-is31fl3236.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: is31fl32xx and Si-En SN32xx IC LED driver
> +
> +maintainers:
> +  - Pavel Machek <pavel@....cz>
> +  - Lee Jones <lee@...nel.org>
> +
> +description: |
> +  The is31fl32xx/SN32xx family of LED drivers are I2C devices with multiple
> +  constant-current channels, each with independent 256-level PWM control.
> +  Each LED is represented as a sub-node of the device.
> +
> +  For more product information please see the links below:
> +    https://www.lumissil.com/assets/pdf/core/IS31FL3236_DS.pdf
> +    https://www.lumissil.com/assets/pdf/core/IS31FL3236A_DS.pdf
> +    https://www.lumissil.com/assets/pdf/core/IS31FL3235_DS.pdf
> +    https://www.lumissil.com/assets/pdf/core/IS31FL3218_DS.pdf
> +    https://www.lumissil.com/assets/pdf/core/IS31FL3216_DS.pdf
> +
> +properties:
> +  compatible:
> +    enum:
> +      - issi,is31fl3236
> +      - issi,is31fl3236a
> +      - issi,is31fl3235
> +      - issi,is31fl3218
> +      - issi,is31fl3216
> +      - si-en,sn3218
> +      - si-en,sn3216
> +
> +  reg:
> +    maxItems: 1
> +
> +  '#address-cells':
> +    const: 1
> +
> +  "#size-cells":
> +    const: 0
> +
> +patternProperties:
> +  "^led@[1-9][0-9]*$":

Unit address should be hex.

> +    type: object
> +    $ref: common.yaml#
> +    additionalProperties: false

unevaluatedProperties: false

That allows other properties from common.yaml which you should allow 
IMO.

> +
> +    properties:
> +      reg:
> +        minItems: 1

maxItems: 1

Is there a known maximum number? If so, add 'maximum'.

> +        description:
> +          LED channel number (1..N)
> +
> +      label: true
> +
> +      linux,default-trigger: true

And drop these 2.

> +
> +    required:
> +      - reg
> +
> +required:
> +  - compatible
> +  - reg
> +  - "#size-cells"
> +  - "#address-cells"
> +
> +additionalProperties: false
> +
> +examples:
> +  - |
> +    #include <dt-bindings/leds/common.h>
> +
> +    i2c {
> +        #address-cells = <1>;
> +        #size-cells = <0>;
> +
> +        s31fl3236: led-controller@3c {

Drop unused labels.

> +          compatible = "issi,is31fl3236";

You indented 4 and then 2 here. Indent by 4 for each level.

> +          reg = <0x3c>;
> +          #address-cells = <1>;
> +          #size-cells = <0>;
> +
> +          led@1 {
> +            reg = <1>;
> +            label = "EB:blue:usr0";
> +          };
> +          led@2 {
> +            reg = <2>;
> +            label = "EB:blue:usr1";
> +          };
> +          led@3 {
> +            reg = <3>;
> +            label = "EB:blue:usr35";
> +          };
> +        };
> +    };
> +...
> +