linux-kernel - Re: [PATCH v5 10/14] dt-bindings: PCI: Add CIX Sky1 PCIe Root Complex bindings

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <27fc6e49-91b5-430a-94b2-eb299d7c3ecf@cixtech.com>
Date: Mon, 30 Jun 2025 13:56:00 +0800
From: Hans Zhang <hans.zhang@...tech.com>
To: "Rob Herring (Arm)" <robh@...nel.org>
Cc: linux-kernel@...r.kernel.org, kw@...ux.com, mpillai@...ence.com,
 lpieralisi@...nel.org, krzk+dt@...nel.org, fugang.duan@...tech.com,
 kwilczynski@...nel.org, linux-pci@...r.kernel.org, mani@...nel.org,
 guoyin.chen@...tech.com, bhelgaas@...gle.com, devicetree@...r.kernel.org,
 conor+dt@...nel.org, cix-kernel-upstream@...tech.com, peter.chen@...tech.com
Subject: Re: [PATCH v5 10/14] dt-bindings: PCI: Add CIX Sky1 PCIe Root Complex
 bindings



On 2025/6/30 13:36, Rob Herring (Arm) wrote:
> [Some people who received this message don't often get email from robh@...nel.org. Learn why this is important at https://aka.ms/LearnAboutSenderIdentification ]
> 
> EXTERNAL EMAIL
> 
> On Mon, 30 Jun 2025 12:15:57 +0800, hans.zhang@...tech.com wrote:
>> From: Hans Zhang <hans.zhang@...tech.com>
>>
>> Document the bindings for CIX Sky1 PCIe Controller configured in
>> root complex mode with five root port.
>>
>> Supports 4 INTx, MSI and MSI-x interrupts from the ARM GICv3 controller.
>>
>> Signed-off-by: Hans Zhang <hans.zhang@...tech.com>
>> Reviewed-by: Peter Chen <peter.chen@...tech.com>
>> Reviewed-by: Manikandan K Pillai <mpillai@...ence.com>
>> ---
>>   .../bindings/pci/cix,sky1-pcie-host.yaml      | 133 ++++++++++++++++++
>>   1 file changed, 133 insertions(+)
>>   create mode 100644 Documentation/devicetree/bindings/pci/cix,sky1-pcie-host.yaml
>>
> 
> My bot found errors running 'make dt_binding_check' on your patch:
> 
> yamllint warnings/errors:
> 
> dtschema/dtc warnings/errors:
> /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/pci/cix,sky1-pcie-host.yaml: properties:compatible:oneOf: [{'const': 'cix,sky1-pcie-host'}] should not be valid under {'items': {'propertyNames': {'const': 'const'}, 'required': ['const']}}
>          hint: Use 'enum' rather than 'oneOf' + 'const' entries
>          from schema $id: http://devicetree.org/meta-schemas/keywords.yaml#
> Error: Documentation/devicetree/bindings/pci/cix,sky1-pcie-host.example.dts:29.47-48 syntax error
> FATAL ERROR: Unable to parse input tree
> make[2]: *** [scripts/Makefile.dtbs:131: Documentation/devicetree/bindings/pci/cix,sky1-pcie-host.example.dtb] Error 1
> make[2]: *** Waiting for unfinished jobs....
> make[1]: *** [/builds/robherring/dt-review-ci/linux/Makefile:1525: dt_binding_check] Error 2
> make: *** [Makefile:248: __sub-make] Error 2
> 
> doc reference errors (make refcheckdocs):
> 
> See https://patchwork.ozlabs.org/project/devicetree-bindings/patch/20250630041601.399921-11-hans.zhang@cixtech.com
> 
> The base for the series is generally the latest rc1. A different dependency
> should be noted in *this* patch.
> 
> If you already ran 'make dt_binding_check' and didn't see the above
> error(s), then make sure 'yamllint' is installed and dt-schema is up to
> date:
> 
> pip3 install dtschema --upgrade
> 
> Please check and re-submit after running the above command yourself. Note
> that DT_SCHEMA_FILES can be set to your schema file to speed up checking
> your schema. However, it must be unset to test all examples with your schema.
> 

Dear Rob,

Thank you very much for your reply and reminder. The next version will fix.

The modification is as follows: make dt_binding_check. There are no errors.

s/sky1,pcie-ctrl-id/cix,pcie-ctrl-id/

Best regards,
Hans