linux-kernel - Re: [PATCH 01/66] kconfig: set MENU_CHANGED to choice when the selected member is changed

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <85d530f3-0c27-48e0-b09b-470c16e08004@infradead.org>
Date: Sun, 29 Jun 2025 23:34:32 -0700
From: Randy Dunlap <rdunlap@...radead.org>
To: Masahiro Yamada <masahiroy@...nel.org>, linux-kbuild@...r.kernel.org
Cc: linux-kernel@...r.kernel.org
Subject: Re: [PATCH 01/66] kconfig: set MENU_CHANGED to choice when the
 selected member is changed

On 6/24/25 8:04 AM, Masahiro Yamada wrote:
> In gconf, choice entries display the selected symbol in the 'Value'
> column, but it is not updated when the selected symbol is changed.
> 
> Set the MENU_CHANGED flag, so it is updated.
> 
> Signed-off-by: Masahiro Yamada <masahiroy@...nel.org>

Probably not related to this change (AFAICT), but I was trying to
reproduce this problem and I cannot do it.

To enable an option (any options, choice or not), I have to double-click
on it or (sometimes, not for choice) I can use Y / N / M on the keyboard.
When I do either of those, the value (including a choice value) is changed.

I mention double-click only because the Help text (Information) says that
clicking will cycle thru Y/M/N.

The Information also says that "dot indicates that it is to be compiled as a module".
I see more of a Dash or Hyphen or just a horizontal bar.

Thanks for reading...

> ---
> 
>  scripts/kconfig/symbol.c | 4 ++++
>  1 file changed, 4 insertions(+)
> 
> diff --git a/scripts/kconfig/symbol.c b/scripts/kconfig/symbol.c
> index d57f8cbba291..26ab10c0fd76 100644
> --- a/scripts/kconfig/symbol.c
> +++ b/scripts/kconfig/symbol.c
> @@ -195,6 +195,10 @@ static void sym_set_changed(struct symbol *sym)
>  
>  	list_for_each_entry(menu, &sym->menus, link)
>  		menu->flags |= MENU_CHANGED;
> +
> +	menu = sym_get_choice_menu(sym);
> +	if (menu)
> +		menu->flags |= MENU_CHANGED;
>  }
>  
>  static void sym_set_all_changed(void)

-- 
~Randy