linux-kernel - Re: [PATCH RFC 04/29] mm/page_alloc: allow for making page types sticky until freed

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <aGI1wLbCs2NhTCL9@hyeyoo>
Date: Mon, 30 Jun 2025 15:59:12 +0900
From: Harry Yoo <harry.yoo@...cle.com>
To: David Hildenbrand <david@...hat.com>
Cc: Zi Yan <ziy@...dia.com>, linux-kernel@...r.kernel.org, linux-mm@...ck.org,
        linux-doc@...r.kernel.org, linuxppc-dev@...ts.ozlabs.org,
        virtualization@...ts.linux.dev, linux-fsdevel@...r.kernel.org,
        Andrew Morton <akpm@...ux-foundation.org>,
        Jonathan Corbet <corbet@....net>,
        Madhavan Srinivasan <maddy@...ux.ibm.com>,
        Michael Ellerman <mpe@...erman.id.au>,
        Nicholas Piggin <npiggin@...il.com>,
        Christophe Leroy <christophe.leroy@...roup.eu>,
        Jerrin Shaji George <jerrin.shaji-george@...adcom.com>,
        Arnd Bergmann <arnd@...db.de>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        "Michael S. Tsirkin" <mst@...hat.com>,
        Jason Wang <jasowang@...hat.com>,
        Xuan Zhuo <xuanzhuo@...ux.alibaba.com>,
        Eugenio Pérez <eperezma@...hat.com>,
        Alexander Viro <viro@...iv.linux.org.uk>,
        Christian Brauner <brauner@...nel.org>, Jan Kara <jack@...e.cz>,
        Matthew Brost <matthew.brost@...el.com>,
        Joshua Hahn <joshua.hahnjy@...il.com>, Rakie Kim <rakie.kim@...com>,
        Byungchul Park <byungchul@...com>, Gregory Price <gourry@...rry.net>,
        Ying Huang <ying.huang@...ux.alibaba.com>,
        Alistair Popple <apopple@...dia.com>,
        Lorenzo Stoakes <lorenzo.stoakes@...cle.com>,
        "Liam R. Howlett" <Liam.Howlett@...cle.com>,
        Vlastimil Babka <vbabka@...e.cz>, Mike Rapoport <rppt@...nel.org>,
        Suren Baghdasaryan <surenb@...gle.com>, Michal Hocko <mhocko@...e.com>,
        "Matthew Wilcox (Oracle)" <willy@...radead.org>,
        Minchan Kim <minchan@...nel.org>,
        Sergey Senozhatsky <senozhatsky@...omium.org>,
        Brendan Jackman <jackmanb@...gle.com>,
        Johannes Weiner <hannes@...xchg.org>, Jason Gunthorpe <jgg@...pe.ca>,
        John Hubbard <jhubbard@...dia.com>, Peter Xu <peterx@...hat.com>,
        Xu Xin <xu.xin16@....com.cn>,
        Chengming Zhou <chengming.zhou@...ux.dev>,
        Miaohe Lin <linmiaohe@...wei.com>,
        Naoya Horiguchi <nao.horiguchi@...il.com>,
        Oscar Salvador <osalvador@...e.de>, Rik van Riel <riel@...riel.com>,
        Qi Zheng <zhengqi.arch@...edance.com>,
        Shakeel Butt <shakeel.butt@...ux.dev>
Subject: Re: [PATCH RFC 04/29] mm/page_alloc: allow for making page types
 sticky until freed

On Mon, Jun 23, 2025 at 05:26:05PM +0200, David Hildenbrand wrote:
> On 18.06.25 20:08, Zi Yan wrote:
> > On 18 Jun 2025, at 14:04, Zi Yan wrote:
> > 
> > > On 18 Jun 2025, at 13:39, David Hildenbrand wrote:
> > > 
> > > > Let's allow for not clearing a page type before freeing a page to the
> > > > buddy.
> > > > 
> > > > We'll focus on having a type set on the first page of a larger
> > > > allocation only.
> > > > 
> > > > With this change, we can reliably identify typed folios even though
> > > > they might be in the process of getting freed, which will come in handy
> > > > in migration code (at least in the transition phase).
> > > > 
> > > > Signed-off-by: David Hildenbrand <david@...hat.com>
> > > > ---
> > > >   mm/page_alloc.c | 3 +++
> > > >   1 file changed, 3 insertions(+)
> > > > 
> > > > diff --git a/mm/page_alloc.c b/mm/page_alloc.c
> > > > index 858bc17653af9..44e56d31cfeb1 100644
> > > > --- a/mm/page_alloc.c
> > > > +++ b/mm/page_alloc.c
> > > > @@ -1380,6 +1380,9 @@ __always_inline bool free_pages_prepare(struct page *page,
> > > >   			mod_mthp_stat(order, MTHP_STAT_NR_ANON, -1);
> > > >   		page->mapping = NULL;
> > > >   	}
> > > > +	if (unlikely(page_has_type(page)))
> > > > +		page->page_type = UINT_MAX;
> > > > +
> > > >   	if (is_check_pages_enabled()) {
> > > >   		if (free_page_is_bad(page))
> > > >   			bad++;
> > > > -- 
> > > > 2.49.0
> > > 
> > > How does this preserve page type? Isn’t page->page_type = UINT_MAX clearing
> > > page_type?
> > 
> > OK, next patch explains it. free_pages_prepare() clears page_type,
> > so that caller does not need to.
> > 
> > I think the message is better to be
> > 
> > mm/page_alloc: clear page_type at page free time
> > 
> > page_type is no longer needed to be cleared before a page is freed, as
> > page free code does that.
> > 
> > With this change, we can reliably identify typed folios even though
> > they might be in the process of getting freed, which will come in handy
> > in migration code (at least in the transition phase).
> 
> 
> I'll change it to
> 
>     mm/page_alloc: let page freeing clear any set page type
>     Currently, any user of page types must clear that type before freeing
>     a page back to the buddy, otherwise we'll run into mapcount related
>     sanity checks (because the page type currently overlays the page
>     mapcount).
>     Let's allow for not clearing the page type by page type users by letting
>     the buddy handle it instead.
>     We'll focus on having a page type set on the first page of a larger
>     allocation only.
>     With this change, we can reliably identify typed folios even though
>     they might be in the process of getting freed, which will come in handy
>     in migration code (at least in the transition phase).

Acked-by: Harry Yoo <harry.yoo@...cle.com>

-- 
Cheers,
Harry / Hyeonggon