linux-kernel - Re: [PATCH v5 14/14] arm64: dts: cix: Enable PCIe on the Orion O6 board

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20250630-stylish-pretty-stoat-bde7f3@krzk-bin>
Date: Mon, 30 Jun 2025 09:32:05 +0200
From: Krzysztof Kozlowski <krzk@...nel.org>
To: hans.zhang@...tech.com
Cc: bhelgaas@...gle.com, lpieralisi@...nel.org, kw@...ux.com, 
	mani@...nel.org, robh@...nel.org, kwilczynski@...nel.org, krzk+dt@...nel.org, 
	conor+dt@...nel.org, mpillai@...ence.com, fugang.duan@...tech.com, 
	guoyin.chen@...tech.com, peter.chen@...tech.com, cix-kernel-upstream@...tech.com, 
	linux-pci@...r.kernel.org, devicetree@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v5 14/14] arm64: dts: cix: Enable PCIe on the Orion O6
 board

On Mon, Jun 30, 2025 at 12:16:01PM +0800, hans.zhang@...tech.com wrote:
> From: Hans Zhang <hans.zhang@...tech.com>
> 
> Add PCIe RC support on Orion O6 board.
> 
> Signed-off-by: Hans Zhang <hans.zhang@...tech.com>
> Reviewed-by: Peter Chen <peter.chen@...tech.com>
> Reviewed-by: Manikandan K Pillai <mpillai@...ence.com>

Where? Please provide lore links. The happened AFTER the SoB, so they
must have been made public, right?

> ---
>  arch/arm64/boot/dts/cix/sky1-orion-o6.dts | 20 ++++++++++++++++++++
>  1 file changed, 20 insertions(+)
> 
> diff --git a/arch/arm64/boot/dts/cix/sky1-orion-o6.dts b/arch/arm64/boot/dts/cix/sky1-orion-o6.dts
> index d74964d53c3b..44710d54ddad 100644
> --- a/arch/arm64/boot/dts/cix/sky1-orion-o6.dts
> +++ b/arch/arm64/boot/dts/cix/sky1-orion-o6.dts
> @@ -37,3 +37,23 @@ linux,cma {
>  &uart2 {
>  	status = "okay";
>  };
> +
> +&pcie_x8_rc {
> +	status = "okay";

And really two people reviewed this trivial changes? Really?

Plus what their review actually checked? This is obviously wrong - not
following DTS coding style, so what such review meant? What did it

Best regards,
Krzysztof