linux-kernel - Re: [PATCH v2] perf test: Add basic callgraph test to record testing

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <898927c3-e85f-4a9a-9374-6fdb49236410@linux.ibm.com>
Date: Mon, 30 Jun 2025 10:01:41 +0200
From: Thomas Richter <tmricht@...ux.ibm.com>
To: Ian Rogers <irogers@...gle.com>, Peter Zijlstra <peterz@...radead.org>,
        Ingo Molnar <mingo@...hat.com>,
        Arnaldo Carvalho de Melo <acme@...nel.org>,
        Namhyung Kim <namhyung@...nel.org>,
        Mark Rutland <mark.rutland@....com>,
        Alexander Shishkin <alexander.shishkin@...ux.intel.com>,
        Jiri Olsa <jolsa@...nel.org>, Adrian Hunter <adrian.hunter@...el.com>,
        Kan Liang <kan.liang@...ux.intel.com>,
        James Clark <james.clark@...aro.org>,
        Dapeng Mi <dapeng1.mi@...ux.intel.com>,
        Chun-Tse Shao <ctshao@...gle.com>, linux-perf-users@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2] perf test: Add basic callgraph test to record testing

On 6/28/25 03:55, Ian Rogers wrote:
> Give some basic perf record callgraph coverage.
> 
> Signed-off-by: Ian Rogers <irogers@...gle.com>
> ---
> v2: Pick up s390's needed "--call-graph dwarf" as spotted by James
>     Clark <james.clark@...aro.org>.
> ---
>  tools/perf/tests/shell/record.sh | 30 ++++++++++++++++++++++++++++++
>  1 file changed, 30 insertions(+)
> 
> diff --git a/tools/perf/tests/shell/record.sh b/tools/perf/tests/shell/record.sh
> index 2022a4f739be..b1ad24fb3b33 100755
> --- a/tools/perf/tests/shell/record.sh
> +++ b/tools/perf/tests/shell/record.sh
> @@ -12,8 +12,10 @@ shelldir=$(dirname "$0")
>  . "${shelldir}"/lib/perf_has_symbol.sh
>  
>  testsym="test_loop"
> +testsym2="brstack"
>  
>  skip_test_missing_symbol ${testsym}
> +skip_test_missing_symbol ${testsym2}
>  
>  err=0
>  perfdata=$(mktemp /tmp/__perf_test.perf.data.XXXXX)
> @@ -359,6 +361,33 @@ test_precise_max() {
>    fi
>  }
>  
> +test_callgraph() {
> +  echo "Callgraph test"
> +
> +  case $(uname -m)
> +  in s390x)
> +       cmd_flags="--call-graph dwarf -e cpu-clock";;
> +     *)
> +       cmd_flags="-g";;
> +  esac
> +
> +  if ! perf record -o "${perfdata}" $cmd_flags perf test -w brstack
> +  then
> +    echo "Callgraph test [Failed missing output]"
> +    err=1
> +    return
> +  fi
> +
> +  if ! perf report -i "${perfdata}" 2>&1 | grep "${testsym2}"
> +  then
> +    echo "Callgraph test [Failed missing symbol]"
> +    err=1
> +    return
> +  fi
> +
> +  echo "Callgraph test [Success]"
> +}
> +
>  # raise the limit of file descriptors to minimum
>  if [[ $default_fd_limit -lt $min_fd_limit ]]; then
>         ulimit -Sn $min_fd_limit
> @@ -374,6 +403,7 @@ test_uid
>  test_leader_sampling
>  test_topdown_leader_sampling
>  test_precise_max
> +test_callgraph
>  
>  # restore the default value
>  ulimit -Sn $default_fd_limit

Works ok for s390

Tested-by: Thomas Richter <tmricht@...ux.ibm.com>
-- 
Thomas Richter, Dept 3303, IBM s390 Linux Development, Boeblingen, Germany
--
IBM Deutschland Research & Development GmbH

Vorsitzender des Aufsichtsrats: Wolfgang Wendt

Geschäftsführung: David Faller

Sitz der Gesellschaft: Böblingen / Registergericht: Amtsgericht Stuttgart, HRB 243294