linux-kernel - Re: [PATCH v4 1/2 fix-v2 ] arm64: refactor the rodata=xxx

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <61f6b895-2632-4d9e-9002-a30655962fb0@amperemail.onmicrosoft.com>
Date: Mon, 30 Jun 2025 09:40:58 +0800
From: Shijie Huang <shijie@...eremail.onmicrosoft.com>
To: Will Deacon <will@...nel.org>,
 Huang Shijie <shijie@...amperecomputing.com>
Cc: catalin.marinas@....com, anshuman.khandual@....com, corbet@....net,
 patches@...erecomputing.com, cl@...ux.com, akpm@...ux-foundation.org,
 thuth@...hat.com, rostedt@...dmis.org, xiongwei.song@...driver.com,
 ardb@...nel.org, inux-doc@...r.kernel.org, linux-kernel@...r.kernel.org,
 linux-arm-kernel@...ts.infradead.org
Subject: Re: [PATCH v4 1/2 fix-v2 ] arm64: refactor the rodata=xxx


On 2025/6/27 23:44, Will Deacon wrote:
> Digging up an old thread...
>
> On Tue, Dec 17, 2024 at 03:17:15PM +0800, Huang Shijie wrote:
>> As per admin guide documentation, "rodata=on" should be the default on
>> platforms. Documentation/admin-guide/kernel-parameters.txt describes
>> these options as
>>
>>     rodata=         [KNL,EARLY]
>>             on      Mark read-only kernel memory as read-only (default).
>>             off     Leave read-only kernel memory writable for debugging.
>>             full    Mark read-only kernel memory and aliases as read-only
>>                     [arm64]
>>
>> But on arm64 platform, "rodata=full" is the default instead. This patch
>> implements the following changes.
>>
>>   - Make "rodata=on" behaviour same as the original "rodata=full"
>>   - Make "rodata=noalias" (new) behaviour same as the original "rodata=on"
>>   - Drop the original "rodata=full"
>>   - Add comment for arch_parse_debug_rodata()
>>   - Update kernel-parameters.txt as required
>>
>> After this patch, the "rodata=on" will be the default on arm64 platform
>> as well.
>>
>> Signed-off-by: Huang Shijie <shijie@...amperecomputing.com>
>> ---
>> Add more comment for "rodata=noalias" in arch_parse_debug_rodata() from Ard.
>> ---
>>   .../admin-guide/kernel-parameters.txt         |  2 +-
>>   arch/arm64/include/asm/setup.h                | 28 +++++++++++++++++--
>>   2 files changed, 27 insertions(+), 3 deletions(-)
> Sorry, but I'd missed this as you'd sent it as a reply to an existing
> series. When you send a new version of a patch, please can you post it
> as a new thread with an updated version?

Okay, I will rebase this patch set and send out it later..


Thanks

Huang Shijie