linux-kernel - RE: [PATCH v5 01/14] dt-bindings: pci: cadence: Extend compatible for new RP configuration

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID:
 <CH2PPF4D26F8E1CC95F84FFBB099955A065A246A@CH2PPF4D26F8E1C.namprd07.prod.outlook.com>
Date: Mon, 30 Jun 2025 08:06:47 +0000
From: Manikandan Karunakaran Pillai <mpillai@...ence.com>
To: Hans Zhang <hans.zhang@...tech.com>, Krzysztof Kozlowski <krzk@...nel.org>
CC: "bhelgaas@...gle.com" <bhelgaas@...gle.com>,
        "lpieralisi@...nel.org"
	<lpieralisi@...nel.org>,
        "kw@...ux.com" <kw@...ux.com>, "mani@...nel.org"
	<mani@...nel.org>,
        "robh@...nel.org" <robh@...nel.org>,
        "kwilczynski@...nel.org" <kwilczynski@...nel.org>,
        "krzk+dt@...nel.org"
	<krzk+dt@...nel.org>,
        "conor+dt@...nel.org" <conor+dt@...nel.org>,
        "fugang.duan@...tech.com" <fugang.duan@...tech.com>,
        "guoyin.chen@...tech.com" <guoyin.chen@...tech.com>,
        "peter.chen@...tech.com"
	<peter.chen@...tech.com>,
        "cix-kernel-upstream@...tech.com"
	<cix-kernel-upstream@...tech.com>,
        "linux-pci@...r.kernel.org"
	<linux-pci@...r.kernel.org>,
        "devicetree@...r.kernel.org"
	<devicetree@...r.kernel.org>,
        "linux-kernel@...r.kernel.org"
	<linux-kernel@...r.kernel.org>
Subject: RE: [PATCH v5 01/14] dt-bindings: pci: cadence: Extend compatible for
 new RP configuration



>EXTERNAL MAIL
>
>
>
>
>On 2025/6/30 15:30, Krzysztof Kozlowski wrote:
>> EXTERNAL EMAIL
>>
>> On Mon, Jun 30, 2025 at 12:15:48PM +0800, hans.zhang@...tech.com wrote:
>>> From: Manikandan K Pillai <mpillai@...ence.com>
>>>
>>> Document the compatible property for HPA (High Performance
>Architecture)
>>> PCIe controller RP configuration.
>>
>> I don't see Conor's comment addressed:
>>
>> https://urldefense.com/v3/__https://lore.kernel.org/linux-
>devicetree/20250424-elm-magma-
>b791798477ab@...d/__;!!EHscmS1ygiU1lA!Bo-
>ayMVqCWXSbSgFpsBZzgk1ADft8pqRQbuOeAhIuAjz0zI015s4dmzxgaWKycqKMn
>1cejS8kKZvjF5xDAse$
>>
>> You cannot just send someone's work and bypassing the review feedback.

I thought the comment was implicitly addressed when the device drivers were separated out based on other review comments in this patch.
To make it more clear, in the next patch I will add the following description for the dt-binding patch

"The High performance architecture is different from legacy architecture controller in design of register banks, 
register definitions, hardware sequences of initialization and is considered as a different device due to the 
large number of changes required in the device driver and hence adding a new compatible."


>>
>>>
>>> Signed-off-by: Manikandan K Pillai <mpillai@...ence.com>
>>
>> SoB.
>
>Dear Krzysztof,
>
>Thank you very much for your reply. The questions mentioned above,
>please answer by Manikandan.
>
>Sorry, I missed it. Will add:
>Signed-off-by: Hans Zhang <hans.zhang@...tech.com>
>
>Best regards,
>Hans
>
>>
>> Best regards,
>> Krzysztof
>>