linux-kernel - Re: [PATCH v2 2/9] gpio: sysfs: only get the dirent reference for the value attr once

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAMRc=Mc3EM8UXKaKgsNx21wR0NAKwqW3iJQV93kmBfk56hbrSw@mail.gmail.com>
Date: Mon, 30 Jun 2025 10:41:24 +0200
From: Bartosz Golaszewski <brgl@...ev.pl>
To: Andy Shevchenko <andriy.shevchenko@...el.com>
Cc: Ahmad Fatoum <a.fatoum@...gutronix.de>, Kent Gibson <warthog618@...il.com>, 
	Jan Lübbe <jlu@...gutronix.de>, Marek Vasut <marex@...x.de>, 
	Geert Uytterhoeven <geert+renesas@...der.be>, Linus Walleij <linus.walleij@...aro.org>, 
	linux-gpio@...r.kernel.org, linux-kernel@...r.kernel.org, 
	Bartosz Golaszewski <bartosz.golaszewski@...aro.org>
Subject: Re: [PATCH v2 2/9] gpio: sysfs: only get the dirent reference for the
 value attr once

On Fri, Jun 27, 2025 at 5:35 PM Andy Shevchenko
<andriy.shevchenko@...el.com> wrote:
>
> On Mon, Jun 23, 2025 at 10:59:50AM +0200, Bartosz Golaszewski wrote:
> >
> > There's no reason to retrieve the reference to the sysfs dirent every
> > time we request an interrupt, we can as well only do it once when
> > exporting the GPIO.
>
> ...
>
> > -     struct kernfs_node *value_kn;
> > +     struct kernfs_node *value_class_node;
>
> This change is not mentioned in the commit message. Why?
>

Yeah, I'll mention it.

Bart