linux-kernel - Re: [PATCH v2 05/11] iio: adc: ad_sigma

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <aGJSoqDxkDQcJ1YE@smile.fi.intel.com>
Date: Mon, 30 Jun 2025 12:02:26 +0300
From: Andy Shevchenko <andriy.shevchenko@...el.com>
To: David Lechner <dlechner@...libre.com>
Cc: Michael Hennerich <Michael.Hennerich@...log.com>,
	Jonathan Cameron <jic23@...nel.org>,
	Nuno Sá <nuno.sa@...log.com>,
	Andy Shevchenko <andy@...nel.org>, Rob Herring <robh@...nel.org>,
	Krzysztof Kozlowski <krzk+dt@...nel.org>,
	Conor Dooley <conor+dt@...nel.org>, Mark Brown <broonie@...nel.org>,
	linux-iio@...r.kernel.org, linux-kernel@...r.kernel.org,
	devicetree@...r.kernel.org, linux-spi@...r.kernel.org
Subject: Re: [PATCH v2 05/11] iio: adc: ad_sigma_delta: audit included headers

On Fri, Jun 27, 2025 at 06:40:01PM -0500, David Lechner wrote:
> Drop linux/iio/sysfs.h since it is unused and replace linux/kernel.h
> with more explicit headers. There are a couple of other headers added
> weren't covered by kernel.h, like linux/gpio/consumer.h that are added
> since the module makes used of those APIs as well.

s/used/use/

> Signed-off-by: David Lechner <dlechner@...libre.com>

...

>  #include <linux/align.h>
> +#include <linux/bitmap.h>
>  #include <linux/bitops.h>

bitops.h is implied by bitmap.h, but I'm fine with this being left untouched.

> +#include <linux/cleanup.h>
> +#include <linux/completion.h>
>  #include <linux/device.h>
>  #include <linux/err.h>
> +#include <linux/export.h>
> +#include <linux/find.h>
> +#include <linux/gpio/consumer.h>
>  #include <linux/interrupt.h>
> -#include <linux/kernel.h>
>  #include <linux/module.h>
> +#include <linux/property.h>
>  #include <linux/slab.h>
>  #include <linux/spi/spi.h>
> +#include <linux/spinlock.h>
> +#include <linux/string.h>
>  #include <linux/types.h>
>  #include <linux/unaligned.h>

-- 
With Best Regards,
Andy Shevchenko