linux-kernel - Re: [PATCH 15/23] md/md-llbitmap: implement llbitmap IO

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <047fb193-3d9c-65d8-6379-84af1a61b283@huaweicloud.com>
Date: Mon, 30 Jun 2025 10:17:36 +0800
From: Yu Kuai <yukuai1@...weicloud.com>
To: Xiao Ni <xni@...hat.com>, Yu Kuai <yukuai1@...weicloud.com>, hch@....de,
 colyli@...nel.org, song@...nel.org
Cc: linux-doc@...r.kernel.org, linux-kernel@...r.kernel.org,
 linux-raid@...r.kernel.org, yi.zhang@...wei.com, yangerkun@...wei.com,
 johnny.chenyi@...wei.com, "yukuai (C)" <yukuai3@...wei.com>
Subject: Re: [PATCH 15/23] md/md-llbitmap: implement llbitmap IO

Hi,

在 2025/06/30 10:07, Xiao Ni 写道:
> Can this for loop run? If one bit is dirty, it must set pctl->dirty. So 
> the second write comes, it finds pctl->dirty is set and 
> llbitmap_infect_dirty_bits function run and return. So it looks like it 
> will not run the for loop.

I don't quite understand what you mean ...

There are two cases:

1) write two bits int the same block twice, then test_and_set_bit() will
pass;
2) write one bit, set block dirty, after bitmap unplug and before
cleaning the bit, then test_and_set_bit() will fail, and the loop will
run.

Thanks,
Kuai