linux-kernel - Re: [PATCH 2/2] HID: magicmouse: avoid setting up battery timer when not needed

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <aGJZxlV-Vyi0EDN7@fedora>
Date: Mon, 30 Jun 2025 11:32:54 +0200
From: José Expósito <jose.exposito89@...il.com>
To: Aditya Garg <gargaditya08@...e.com>
Cc: Jiri Kosina <jikos@...nel.org>, Benjamin Tissoires <bentiss@...nel.org>,
	linux-input@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 2/2] HID: magicmouse: avoid setting up battery timer when
 not needed

Hi Aditya,

On Wed, Jun 25, 2025 at 07:46:04PM +0530, Aditya Garg wrote:
> Currently, the battery timer is set up for all devices using
> hid-magicmouse, irrespective of whether they actually need it or not.
> 
> The current implementation requires the battery timer for Magic Mouse 2
> and Magic Trackpad 2 when connected via USB only. Add checks to ensure
> that the battery timer is only set up when they are connected via USB.
> 
> Fixes: 0b91b4e4dae6 ("HID: magicmouse: Report battery level over USB")
> Cc: stable@...r.kernel.org
> Signed-off-by: Aditya Garg <gargaditya08@...e.com>
> ---
>  drivers/hid/hid-magicmouse.c | 36 +++++++++++++++++++++++-------------
>  1 file changed, 23 insertions(+), 13 deletions(-)
> 
> diff --git a/drivers/hid/hid-magicmouse.c b/drivers/hid/hid-magicmouse.c
> index f49405d38..3e531905b 100644
> --- a/drivers/hid/hid-magicmouse.c
> +++ b/drivers/hid/hid-magicmouse.c
> @@ -863,18 +863,22 @@ static int magicmouse_probe(struct hid_device *hdev,
>  		return ret;
>  	}
>  
> -	timer_setup(&msc->battery_timer, magicmouse_battery_timer_tick, 0);
> -	mod_timer(&msc->battery_timer,
> -		  jiffies + msecs_to_jiffies(USB_BATTERY_TIMEOUT_MS));
> -	magicmouse_fetch_battery(hdev);
> -
> -	if (id->vendor == USB_VENDOR_ID_APPLE &&
> -	    (id->product == USB_DEVICE_ID_APPLE_MAGICMOUSE2 ||
> -	     id->product == USB_DEVICE_ID_APPLE_MAGICMOUSE2_USBC ||
> -	     ((id->product == USB_DEVICE_ID_APPLE_MAGICTRACKPAD2 ||
> -	       id->product == USB_DEVICE_ID_APPLE_MAGICTRACKPAD2_USBC) &&
> -	      hdev->type != HID_TYPE_USBMOUSE)))
> -		return 0;
> +	if (id->vendor == USB_VENDOR_ID_APPLE) {
> +		bool is_mouse2 = (id->product == USB_DEVICE_ID_APPLE_MAGICMOUSE2 ||
> +				  id->product == USB_DEVICE_ID_APPLE_MAGICMOUSE2_USBC);
> +		bool is_trackpad2 = (id->product == USB_DEVICE_ID_APPLE_MAGICTRACKPAD2 ||
> +				     id->product == USB_DEVICE_ID_APPLE_MAGICTRACKPAD2_USBC);
> +
> +		if (is_mouse2 || is_trackpad2) {
> +			timer_setup(&msc->battery_timer, magicmouse_battery_timer_tick, 0);
> +			mod_timer(&msc->battery_timer,
> +				  jiffies + msecs_to_jiffies(USB_BATTERY_TIMEOUT_MS));
> +			magicmouse_fetch_battery(hdev);
> +		}
> +
> +		if (is_mouse2 || (is_trackpad2 && hdev->type != HID_TYPE_USBMOUSE))
> +			return 0;
> +	}

Instead of duplicating these conditions here and in magicmouse_remove(),
you could move them into a helper function.

Also, watch out the `err_stop_hw:` error case, the timer could be used
there uninitialized.

Jose

>  	if (!msc->input) {
>  		hid_err(hdev, "magicmouse input not registered\n");
> @@ -947,7 +951,13 @@ static void magicmouse_remove(struct hid_device *hdev)
>  
>  	if (msc) {
>  		cancel_delayed_work_sync(&msc->work);
> -		timer_delete_sync(&msc->battery_timer);
> +		if (hdev->vendor == USB_VENDOR_ID_APPLE &&
> +		    (hdev->product == USB_DEVICE_ID_APPLE_MAGICMOUSE2 ||
> +		     hdev->product == USB_DEVICE_ID_APPLE_MAGICMOUSE2_USBC ||
> +		     hdev->product == USB_DEVICE_ID_APPLE_MAGICTRACKPAD2 ||
> +		     hdev->product == USB_DEVICE_ID_APPLE_MAGICTRACKPAD2_USBC))
> +
> +			timer_delete_sync(&msc->battery_timer);
>  	}
>  
>  	hid_hw_stop(hdev);
> -- 
> 2.43.0
>