linux-kernel - Re: [PATCH 11/66] kconfig: gconf: remove meaningless code in init_main

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <f812ecbb-23bd-424e-91e5-ad278dac4f4d@infradead.org>
Date: Sun, 29 Jun 2025 19:25:59 -0700
From: Randy Dunlap <rdunlap@...radead.org>
To: Masahiro Yamada <masahiroy@...nel.org>, linux-kbuild@...r.kernel.org
Cc: linux-kernel@...r.kernel.org
Subject: Re: [PATCH 11/66] kconfig: gconf: remove meaningless code in
 init_main_window()



On 6/24/25 8:04 AM, Masahiro Yamada wrote:
> The 'widget' variable is set, but not used in later code.
> 
> Signed-off-by: Masahiro Yamada <masahiroy@...nel.org>

Acked-by: Randy Dunlap <rdunlap@...radead.org>

> ---
> 
>  scripts/kconfig/gconf.c | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/scripts/kconfig/gconf.c b/scripts/kconfig/gconf.c
> index 7960c456e3b9..4b5befa4f685 100644
> --- a/scripts/kconfig/gconf.c
> +++ b/scripts/kconfig/gconf.c
> @@ -129,7 +129,6 @@ static void init_main_window(const gchar *glade_file)
>  	conf_set_changed_callback(conf_changed);
>  
>  	style = gtk_widget_get_style(main_wnd);
> -	widget = glade_xml_get_widget(xml, "toolbar1");
>  
>  	replace_button_icon(xml, main_wnd->window, style,
>  			    "button4", (gchar **) xpm_single_view);

-- 
~Randy