linux-kernel - Re: [PATCH 1/1] spi: cadence-quadspi: fix cleanup of rx

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <dc6a3c05-27cf-4e72-aacd-0d374610ae60@ti.com>
Date: Mon, 30 Jun 2025 16:10:24 +0530
From: Santhosh Kumar K <s-k6@...com>
To: <khairul.anuar.romli@...era.com>, Mark Brown <broonie@...nel.org>,
        "open
 list:SPI SUBSYSTEM" <linux-spi@...r.kernel.org>,
        open list
	<linux-kernel@...r.kernel.org>,
        Matthew Gerlach <matthew.gerlach@...era.com>,
        Dan Carpenter <dan.carpenter@...aro.org>
Subject: Re: [PATCH 1/1] spi: cadence-quadspi: fix cleanup of rx_chan on
 failure paths

Hello Khairul,

On 30/06/25 14:41, khairul.anuar.romli@...era.com wrote:
> From: Khairul Anuar Romli <khairul.anuar.romli@...era.com>
> 
> Remove incorrect checks on cqspi->rx_chan that cause driver breakage
> during failure cleanup. Ensure proper resource freeing on the success
> path when operating in cqspi->use_direct_mode, preventing leaks and
> improving stability.
> 
> Signed-off-by: Khairul Anuar Romli <khairul.anuar.romli@...era.com>

Please add 'Fixes' tag and add stable in cc.

Regards,
Santhosh.

> ---
>   drivers/spi/spi-cadence-quadspi.c | 5 -----
>   1 file changed, 5 deletions(-)
> 
> diff --git a/drivers/spi/spi-cadence-quadspi.c b/drivers/spi/spi-cadence-quadspi.c
> index aa1932ba17cb..d3c78f59b22c 100644
> --- a/drivers/spi/spi-cadence-quadspi.c
> +++ b/drivers/spi/spi-cadence-quadspi.c
> @@ -1960,11 +1960,6 @@ static int cqspi_probe(struct platform_device *pdev)
>   
>   	pm_runtime_enable(dev);
>   
> -	if (cqspi->rx_chan) {
> -		dma_release_channel(cqspi->rx_chan);
> -		goto probe_setup_failed;
> -	}
> -
>   	pm_runtime_set_autosuspend_delay(dev, CQSPI_AUTOSUSPEND_TIMEOUT);
>   	pm_runtime_use_autosuspend(dev);
>   	pm_runtime_get_noresume(dev);