linux-kernel - Re: [PATCH 1/2] Move FCH header to a location accessible by all archs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <a6ccabd7-1436-ff73-398f-b92e546d3701@linux.intel.com>
Date: Mon, 30 Jun 2025 13:46:35 +0300 (EEST)
From: Ilpo Järvinen <ilpo.jarvinen@...ux.intel.com>
To: Andi Shyti <andi.shyti@...nel.org>
cc: Hans de Goede <hansg@...nel.org>, Mario Limonciello <superm1@...nel.org>, 
    Ingo Molnar <mingo@...hat.com>, Thomas Gleixner <tglx@...utronix.de>, 
    Borislav Petkov <bp@...en8.de>, Dave Hansen <dave.hansen@...ux.intel.com>, 
    "maintainer:X86 ARCHITECTURE (32-BIT AND 64-BIT)" <x86@...nel.org>, 
    "H . Peter Anvin" <hpa@...or.com>, Jean Delvare <jdelvare@...e.com>, 
    Shyam Sundar S K <Shyam-sundar.S-k@....com>, 
    Hans de Goede <hdegoede@...hat.com>, 
    Mario Limonciello <mario.limonciello@....com>, 
    "open list:X86 ARCHITECTURE (32-BIT AND 64-BIT)" <linux-kernel@...r.kernel.org>, 
    "open list:I2C SUBSYSTEM HOST DRIVERS" <linux-i2c@...r.kernel.org>, 
    "open list:AMD PMC DRIVER" <platform-driver-x86@...r.kernel.org>
Subject: Re: [PATCH 1/2] Move FCH header to a location accessible by all
 archs

On Wed, 25 Jun 2025, Andi Shyti wrote:

> Hi,
> 
> On Thu, Jun 12, 2025 at 10:36:31AM +0200, Hans de Goede wrote:
> > Hi,
> > 
> > On 10-Jun-25 10:58 PM, Mario Limonciello wrote:
> > > From: Mario Limonciello <mario.limonciello@....com>
> > > 
> > > A new header fch.h was created to store registers used by different AMD
> > > drivers.  This header was included by i2c-piix4 in
> > > commit 624b0d5696a8 ("i2c: piix4, x86/platform: Move the SB800 PIIX4 FCH
> > > definitions to <asm/amd/fch.h>"). To prevent compile failures on non-x86
> > > archs i2c-piix4 was set to only compile on x86 by commit 7e173eb82ae9717
> > > ("i2c: piix4: Make CONFIG_I2C_PIIX4 dependent on CONFIG_X86").
> > > This was not a good decision because loongarch and mips both actually
> > > support i2c-piix4 and set it enabled in the defconfig.
> > > 
> > > Move the header to a location accessible by all architectures.
> > > 
> > > Fixes: 624b0d5696a89 ("i2c: piix4, x86/platform: Move the SB800 PIIX4 FCH definitions to <asm/amd/fch.h>")
> > > Suggested-by: Hans de Goede <hansg@...nel.org>
> > > Signed-off-by: Mario Limonciello <mario.limonciello@....com>
> > 
> > Thanks, patch looks good to me:
> > 
> > Reviewed-by: Hans de Goede <hansg@...nel.org>
> 
> I don't see this series in yet. I thought you were taking it,
> shall I take it through i2c?

I'm sorry I seem to have missed this inquiry until now. I thought x86 
would handle it this but apparently they haven't.

(I'm the primary person handling pdx86 patches, not Hans any more).

I can take this now.

-- 
 i.