linux-kernel - Re: [PATCH v2] platform/mellanox: mlxreg-lc: Fix logic error in power state check

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <175128165916.8413.10898065665792776275.b4-ty@linux.intel.com>
Date: Mon, 30 Jun 2025 14:07:39 +0300
From: Ilpo Järvinen <ilpo.jarvinen@...ux.intel.com>
To: hansg@...nel.org, vadimp@...dia.com, 
 platform-driver-x86@...r.kernel.org, Alok Tiwari <alok.a.tiwari@...cle.com>
Cc: darren.kenny@...cle.com, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2] platform/mellanox: mlxreg-lc: Fix logic error in
 power state check

On Mon, 30 Jun 2025 03:58:08 -0700, Alok Tiwari wrote:

> Fixes a logic issue in mlxreg_lc_completion_notify() where the
> intention was to check if MLXREG_LC_POWERED flag is not set before
> powering on the device.
> 
> The original code used "state & ~MLXREG_LC_POWERED" to check for the
> absence of the POWERED bit. However this condition evaluates to true
> even when other bits are set, leading to potentially incorrect
> behavior.
> 
> [...]


Thank you for your contribution, it has been applied to my local
review-ilpo-fixes branch. Note it will show up in the public
platform-drivers-x86/review-ilpo-fixes branch only once I've pushed my
local branch there, which might take a while.

The list of commits applied:
[1/1] platform/mellanox: mlxreg-lc: Fix logic error in power state check
      commit: 644bec18e705ca41d444053407419a21832fcb2f

--
 i.