linux-kernel - Re: [PATCH 26/66] kconfig: gconf: grey out button for current view

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <5cc3a3f9-4ca5-49f6-a35a-1cca44dc8bc4@infradead.org>
Date: Sun, 29 Jun 2025 19:53:20 -0700
From: Randy Dunlap <rdunlap@...radead.org>
To: Masahiro Yamada <masahiroy@...nel.org>, linux-kbuild@...r.kernel.org
Cc: linux-kernel@...r.kernel.org
Subject: Re: [PATCH 26/66] kconfig: gconf: grey out button for current view



On 6/24/25 8:05 AM, Masahiro Yamada wrote:
> This clarifies which view is currently selected.
> 
> Signed-off-by: Masahiro Yamada <masahiroy@...nel.org>

Looks good.


Acked-by: Randy Dunlap <rdunlap@...radead.org>
Tested-by: Randy Dunlap <rdunlap@...radead.org>

> ---
> 
>  scripts/kconfig/gconf.c | 15 +++++++++++++--
>  1 file changed, 13 insertions(+), 2 deletions(-)
> 
> diff --git a/scripts/kconfig/gconf.c b/scripts/kconfig/gconf.c
> index b67ebff3f288..67c5c965aaf8 100644
> --- a/scripts/kconfig/gconf.c
> +++ b/scripts/kconfig/gconf.c
> @@ -38,8 +38,7 @@ static GtkWidget *tree2_w;	// right frame
>  static GtkWidget *text_w;
>  static GtkWidget *hpaned;
>  static GtkWidget *vpaned;
> -static GtkWidget *back_btn;
> -static GtkWidget *save_btn;
> +static GtkWidget *back_btn, *save_btn, *single_btn, *split_btn, *full_btn;
>  static GtkWidget *save_menu_item;
>  
>  static GtkTextTag *tag1, *tag2;
> @@ -85,18 +84,25 @@ static void set_view_mode(enum view_mode mode)
>  		gtk_paned_set_position(GTK_PANED(hpaned), 0);
>  	}
>  
> +	gtk_widget_set_sensitive(single_btn, TRUE);
> +	gtk_widget_set_sensitive(split_btn, TRUE);
> +	gtk_widget_set_sensitive(full_btn, TRUE);
> +
>  	switch (mode) {
>  	case SINGLE_VIEW:
>  		current = &rootmenu;
>  		display_tree_part();
> +		gtk_widget_set_sensitive(single_btn, FALSE);
>  		break;
>  	case SPLIT_VIEW:
>  		gtk_tree_store_clear(tree2);
>  		display_list();
> +		gtk_widget_set_sensitive(split_btn, FALSE);
>  		break;
>  	case FULL_VIEW:
>  		gtk_tree_store_clear(tree2);
>  		display_tree(&rootmenu);
> +		gtk_widget_set_sensitive(full_btn, FALSE);
>  		break;
>  	}
>  
> @@ -1167,10 +1173,15 @@ static void init_main_window(const gchar *glade_file)
>  
>  	style = gtk_widget_get_style(main_wnd);
>  
> +	single_btn = glade_xml_get_widget(xml, "button4");
>  	replace_button_icon(xml, main_wnd->window, style,
>  			    "button4", (gchar **) xpm_single_view);
> +
> +	split_btn = glade_xml_get_widget(xml, "button5");
>  	replace_button_icon(xml, main_wnd->window, style,
>  			    "button5", (gchar **) xpm_split_view);
> +
> +	full_btn = glade_xml_get_widget(xml, "button6");
>  	replace_button_icon(xml, main_wnd->window, style,
>  			    "button6", (gchar **) xpm_tree_view);
>  

-- 
~Randy