linux-kernel - Re: [PATCH 30/66] kconfig: gconf: remove glade_xml_signal

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <c6033a11-82ae-49a9-aec1-ac820b9ce6ee@infradead.org>
Date: Sun, 29 Jun 2025 19:58:37 -0700
From: Randy Dunlap <rdunlap@...radead.org>
To: Masahiro Yamada <masahiroy@...nel.org>, linux-kbuild@...r.kernel.org
Cc: linux-kernel@...r.kernel.org
Subject: Re: [PATCH 30/66] kconfig: gconf: remove
 glade_xml_signal_autoconnect() call



On 6/24/25 8:05 AM, Masahiro Yamada wrote:
> Now that all signals are connected manually, this is no longer
> unnecessary.

Double negative. Or is that what you meant?

is no longer necessary.
is now unnecessary.

> 
> Signed-off-by: Masahiro Yamada <masahiroy@...nel.org>
> ---
> 
>  scripts/kconfig/gconf.c | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/scripts/kconfig/gconf.c b/scripts/kconfig/gconf.c
> index 02bbb7ce4c4a..09537245213a 100644
> --- a/scripts/kconfig/gconf.c
> +++ b/scripts/kconfig/gconf.c
> @@ -1120,7 +1120,6 @@ static void init_main_window(const gchar *glade_file)
>  	xml = glade_xml_new(glade_file, "window1", NULL);
>  	if (!xml)
>  		g_error("GUI loading failed !\n");
> -	glade_xml_signal_autoconnect(xml);
>  
>  	main_wnd = glade_xml_get_widget(xml, "window1");
>  	g_signal_connect(main_wnd, "destroy",

-- 
~Randy