linux-kernel - Re: [PATCH v5 1/1] selftests/mm/uffd: Refactor non-composite global vars into struct

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CALkFLLJ8VR73u4B5Q8q-eCZWNbzBrkVj7B2GwVexkuu6ma6FVA@mail.gmail.com>
Date: Mon, 30 Jun 2025 16:55:32 +0530
From: Ujwal Kundur <ujwal.kundur@...il.com>
To: Peter Xu <peterx@...hat.com>
Cc: Brendan Jackman <jackmanb@...gle.com>, Andrew Morton <akpm@...ux-foundation.org>, shuah@...nel.org, 
	linux-kernel@...r.kernel.org, linux-kselftest@...r.kernel.org, 
	linux-mm@...ck.org
Subject: Re: [PATCH v5 1/1] selftests/mm/uffd: Refactor non-composite global
 vars into struct

> The script I mentioned in that other mail should help with this:
>
> https://github.com/bjackman/linux/blob/github-base/.github/scripts/run_local.sh
>
> That's my hacky attempt at a "hermetic" runner for these tests, it
> ought to let you get the exact Kconfig, userspace, and QEMU command
> that I used when I hit the issue.
>
> The GitHub workflow definition shows how to get its dependencies
> installed on a Debian-alike:
>
> https://github.com/bjackman/linux/blob/github-base/.github/workflows/test.yaml

Thanks for sharing this, I was able to reproduce and fix the problem.
Turns out char *area_src_alias, area_dst_alias, area_remap were left
uninitialized in uffd_test_ctx_init while it was working before this
refactor because of the global nature of these variables.
Using virtme-ng also helps me ensure that the next spin on this patch
will work :)

> Ideally the test changes
> should run the same before/after that series applied.  Meanwhile, no
> conflict expected between the two, hence no worry on the order to land.

Sorry, I meant to link the uffd_poison_test changes [1], I've rebased
on top of those changes.

Will send a v6 soon.

[1] https://lore.kernel.org/all/20250620150058.1729489-1-peterx@redhat.com/

Thanks,
Ujwal