linux-kernel - Re: [PATCH v2 7/8] auxdisplay: Add Titanmec TM16xx 7-segment display controllers driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <532c88b8-d938-4633-ac09-12bb3080a023@kernel.org>
Date: Mon, 30 Jun 2025 13:39:25 +0200
From: Krzysztof Kozlowski <krzk@...nel.org>
To: Andy Shevchenko <andriy.shevchenko@...el.com>, ojeda@...nel.org
Cc: Jean-François Lessard <jefflessard3@...il.com>,
 Andy Shevchenko <andy@...nel.org>, Rob Herring <robh@...nel.org>,
 Krzysztof Kozlowski <krzk+dt@...nel.org>, Conor Dooley
 <conor+dt@...nel.org>, Geert Uytterhoeven <geert@...ux-m68k.org>,
 devicetree@...r.kernel.org, linux-leds@...r.kernel.org,
 linux-kernel@...r.kernel.org, Andreas Färber
 <afaerber@...e.de>, Boris Gjenero <boris.gjenero@...il.com>,
 Christian Hewitt <christianshewitt@...il.com>,
 Heiner Kallweit <hkallweit1@...il.com>,
 Paolo Sabatino <paolo.sabatino@...il.com>
Subject: Re: [PATCH v2 7/8] auxdisplay: Add Titanmec TM16xx 7-segment display
 controllers driver

On 30/06/2025 11:54, Andy Shevchenko wrote:
> On Mon, Jun 30, 2025 at 11:27:21AM +0200, Krzysztof Kozlowski wrote:
>> On 30/06/2025 09:27, Andy Shevchenko wrote:
>>> On Mon, Jun 30, 2025 at 08:12:16AM +0200, Krzysztof Kozlowski wrote:
>>>> On 29/06/2025 15:18, Jean-François Lessard wrote:
> 
> ...
> 
>>>>> +	display->leds =
>>>>> +		devm_kcalloc(dev, display->num_leds, sizeof(*display->leds), GFP_KERNEL);
>>>>
>>>> Wrong wrapping. Use kernel style, not clang style.
>>>>
>>>>
>>>>> +	if (!display->leds)
>>>>> +		return -ENOMEM;
>>>
>>> Just wondering how .clang-format is official? Note some of the maintainers even
>>
>> First time I hear above clang style is preferred. Where is it expected?
> 
> Documented here:
> https://www.kernel.org/doc/html/latest/process/coding-style.html#you-ve-made-a-mess-of-it

I mean, which maintainers prefer such style of wrapping. Above I know,
but it does not solve the discussion we have here - above line wrapping
preferred by clang and opposite to most of the kernel code.

> 
> For example, discussed here
> https://lore.kernel.org/lkml/CAPcyv4ij3s+9uO0f9aLHGj3=ACG7hAjZ0Rf=tyFmpt3+uQyymw@mail.gmail.com/


Heh, I read it and two emails earlier and still could not get they
prefer to wrap at assignment instead of standard checkpatch-preferred
wrapping at arguments.

> or here
> https://lore.kernel.org/lkml/64dbeffcf243a_47b5729487@dwillia2-mobl3.amr.corp.intel.com.notmuch/

This is line length, so not the problem discussed here.


> or
> ...
> 
>> I assume clang-format is half-working and should not be used blindly,
>> but fixed to match actual kernel coding style.
> 
> That sounds like the case, at least in accordance with Miguel.
> 
>>> prefer (ugly in some cases in my opinion) style because it's generated by the
>>> clang-format.
> 


Best regards,
Krzysztof