linux-kernel - Re: [PATCH v3 1/2] x86/smpboot: Decrapify build_sched

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <87bjq5o0bf.ffs@tglx>
Date: Mon, 30 Jun 2025 14:56:04 +0200
From: Thomas Gleixner <tglx@...utronix.de>
To: Li Chen <me@...ux.beauty>, Peter Zijlstra <peterz@...radead.org>
Cc: Ingo Molnar <mingo@...hat.com>, Borislav Petkov <bp@...en8.de>, Dave
 Hansen <dave.hansen@...ux.intel.com>, x86 <x86@...nel.org>, "H . Peter
 Anvin" <hpa@...or.com>, "Rafael J . Wysocki" <rafael.j.wysocki@...el.com>,
 K Prateek Nayak <kprateek.nayak@....com>, Sohil Mehta
 <sohil.mehta@...el.com>, Brian Gerst <brgerst@...il.com>, Patryk Wlazlyn
 <patryk.wlazlyn@...ux.intel.com>, linux-kernel
 <linux-kernel@...r.kernel.org>, Li Chen <chenl311@...natelecom.cn>
Subject: Re: [PATCH v3 1/2] x86/smpboot: Decrapify build_sched_topology()

On Mon, Jun 30 2025 at 08:21, Li Chen wrote:
>  ---- On Wed, 25 Jun 2025 16:28:19 +0800  Peter Zijlstra <peterz@...radead.org> wrote --- 
>  > Urgh, this patch is doing at least 4 things and nigh on unreadable
>  > because of that.
>  > 
>  >  - introduces DOMAIN() helper
>  >  - drops (the now pointless) SD_INIT_NAME() helper
>  >  - drops CONFIG_SCHED_SMT (x86 special)
>  >  - moves to static initialize and truncate
>
> Thanks for your review, I would split this Thomas's patch to 4 different patches
> and preserve his signoff

Nah. Just split it up and add

     Suggested-by: Thomas ....