linux-kernel - Re: [PATCH v4 14/22] x86/mce: Separate global and per-CPU quirks

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20250630130041.GC5995@yaz-khff2.amd.com>
Date: Mon, 30 Jun 2025 09:00:41 -0400
From: Yazen Ghannam <yazen.ghannam@....com>
To: Nikolay Borisov <nik.borisov@...e.com>
Cc: x86@...nel.org, Tony Luck <tony.luck@...el.com>,
	"Rafael J. Wysocki" <rafael@...nel.org>,
	Len Brown <lenb@...nel.org>, linux-kernel@...r.kernel.org,
	linux-edac@...r.kernel.org, Smita.KoralahalliChannabasappa@....com,
	Qiuxu Zhuo <qiuxu.zhuo@...el.com>, linux-acpi@...r.kernel.org
Subject: Re: [PATCH v4 14/22] x86/mce: Separate global and per-CPU quirks

On Fri, Jun 27, 2025 at 02:02:22PM +0300, Nikolay Borisov wrote:
> 
> 
> On 6/24/25 17:16, Yazen Ghannam wrote:
> > Many quirks are global configuration settings and a handful apply to
> > each CPU.
> > 
> > Move the per-CPU quirks to vendor init to execute them on each online
> > CPU. Set the global quirks during BSP-only init so they're only executed
> > once and early.
> > 
> > Reviewed-by: Qiuxu Zhuo <qiuxu.zhuo@...el.com>
> > Tested-by: Tony Luck <tony.luck@...el.com>
> > Reviewed-by: Tony Luck <tony.luck@...el.com>
> > Signed-off-by: Yazen Ghannam <yazen.ghannam@....com>
> 
> 
> After this patch the code ends up with 2 sets of quirk functions with very
> confusing names:
> 
> amd_apply_quirks/apply_quirks_amd
> intel_apply_quirks/apply_quirks_intel
> 
> 
> Better naming convention would be something along the lines of:
> 
> amd_apply_global_quirks/amd_apply_cpu_quirks and the same for intel.
> 

Yes, good point. I'll make this change.

Thanks,
Yazen