linux-kernel - Re: [PATCH 02/66] kconfig: qconf: do not show checkbox icon for choice

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAK7LNAQo5DKLdrn53yW3A0WnKxfyxJxyrxt8bDTVJvTM8kMyRw@mail.gmail.com>
Date: Mon, 30 Jun 2025 12:36:36 +0900
From: Masahiro Yamada <masahiroy@...nel.org>
To: Randy Dunlap <rdunlap@...radead.org>
Cc: linux-kbuild@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 02/66] kconfig: qconf: do not show checkbox icon for choice

On Mon, Jun 30, 2025 at 5:15 AM Randy Dunlap <rdunlap@...radead.org> wrote:
>
>
>
> On 6/24/25 8:04 AM, Masahiro Yamada wrote:
> > When you select "Show All Options" or "Show Prompt Options", choice
> > entries display a check box icon, but this has no point because
> > choice is always y since commit
>
>                      since commit _____________________.


since commit fde192511bdb ("kconfig: remove tristate choice support").


I will fix it.
Thanks.



> >
> > Signed-off-by: Masahiro Yamada <masahiroy@...nel.org>
> > ---
> >
> >  scripts/kconfig/qconf.cc | 11 ++++++-----
> >  1 file changed, 6 insertions(+), 5 deletions(-)
> >
> > diff --git a/scripts/kconfig/qconf.cc b/scripts/kconfig/qconf.cc
> > index eaa465b0ccf9..546738a5c3b1 100644
> > --- a/scripts/kconfig/qconf.cc
> > +++ b/scripts/kconfig/qconf.cc
> > @@ -92,7 +92,6 @@ void ConfigItem::updateMenu(void)
> >  {
> >       ConfigList* list;
> >       struct symbol* sym;
> > -     struct property *prop;
> >       QString prompt;
> >       int type;
> >       tristate expr;
> > @@ -105,11 +104,10 @@ void ConfigItem::updateMenu(void)
> >       }
> >
> >       sym = menu->sym;
> > -     prop = menu->prompt;
> >       prompt = menu_get_prompt(menu);
> >
> > -     if (prop) switch (prop->type) {
> > -     case P_MENU:
> > +     switch (menu->type) {
> > +     case M_MENU:
> >               if (list->mode == singleMode) {
> >                       /* a menuconfig entry is displayed differently
> >                        * depending whether it's at the view root or a child.
> > @@ -123,10 +121,13 @@ void ConfigItem::updateMenu(void)
> >                       setIcon(promptColIdx, QIcon());
> >               }
> >               goto set_prompt;
> > -     case P_COMMENT:
> > +     case M_COMMENT:
> >               setIcon(promptColIdx, QIcon());
> >               prompt = "*** " + prompt + " ***";
> >               goto set_prompt;
> > +     case M_CHOICE:
> > +             setIcon(promptColIdx, QIcon());
> > +             goto set_prompt;
> >       default:
> >               ;
> >       }
>
> --
> ~Randy
>


-- 
Best Regards
Masahiro Yamada