linux-kernel - RE: [char-misc-next v2 1/5] mei: set parent for char device

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CY5PR11MB6366307E6C7330B44132C6D7ED46A@CY5PR11MB6366.namprd11.prod.outlook.com>
Date: Mon, 30 Jun 2025 13:02:12 +0000
From: "Usyskin, Alexander" <alexander.usyskin@...el.com>
To: Greg Kroah-Hartman <gregkh@...uxfoundation.org>
CC: "Abliyev, Reuven" <reuven.abliyev@...el.com>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: RE: [char-misc-next v2 1/5] mei: set parent for char device

> Subject: Re: [char-misc-next v2 1/5] mei: set parent for char device
> 
> On Mon, Jun 30, 2025 at 12:19:38PM +0300, Alexander Usyskin wrote:
> > Connect char device to parent device to avoid
> > parent device unload while char device is
> > still held open by user-space.
> 
> No, that's not what cdev_set_parent() does.
> 
https://elixir.bootlin.com/linux/v6.16-rc3/source/fs/char_dev.c#L511
* cdev_set_parent() sets a parent kobject which will be referenced
 * appropriately so the parent is not freed before the cdev. This
 * should be called before cdev_add.

This is what written there. Is my interpretation wrong?

> Also, why not wrap your lines at 72 columns?

Ops, missed this while preparing series, will fix.

> 
> thanks,
> 
> greg k-h

- - 
Thanks,
Sasha