[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20250701150631.0256539b@fedora.home>
Date: Tue, 1 Jul 2025 15:06:31 +0200
From: Maxime Chevallier <maxime.chevallier@...tlin.com>
To: Simon Horman <horms@...nel.org>
Cc: davem@...emloft.net, netdev@...r.kernel.org,
linux-kernel@...r.kernel.org, linux-arm-msm@...r.kernel.org,
thomas.petazzoni@...tlin.com, Andrew Lunn <andrew@...n.ch>, Jakub Kicinski
<kuba@...nel.org>, Eric Dumazet <edumazet@...gle.com>, Paolo Abeni
<pabeni@...hat.com>, Russell King <linux@...linux.org.uk>,
linux-arm-kernel@...ts.infradead.org, Christophe Leroy
<christophe.leroy@...roup.eu>, Herve Codina <herve.codina@...tlin.com>,
Florian Fainelli <f.fainelli@...il.com>, Heiner Kallweit
<hkallweit1@...il.com>, Vladimir Oltean <vladimir.oltean@....com>,
Köry Maincent <kory.maincent@...tlin.com>, Marek
Behún <kabel@...nel.org>, Oleksij Rempel
<o.rempel@...gutronix.de>, Nicolò Veronese
<nicveronese@...il.com>, mwojtas@...omium.org, Antoine Tenart
<atenart@...nel.org>, devicetree@...r.kernel.org, Conor Dooley
<conor+dt@...nel.org>, Krzysztof Kozlowski <krzk+dt@...nel.org>, Rob
Herring <robh@...nel.org>, Romain Gantois <romain.gantois@...tlin.com>,
Daniel Golle <daniel@...rotopia.org>, Dimitri Fedrau
<dimitri.fedrau@...bherr.com>
Subject: Re: [PATCH net-next v7 04/15] net: phy: Introduce PHY ports
representation
On Tue, 1 Jul 2025 14:02:43 +0100
Simon Horman <horms@...nel.org> wrote:
> On Mon, Jun 30, 2025 at 04:33:03PM +0200, Maxime Chevallier wrote:
>
> ...
>
> > +/**
> > + * phy_port_get_type() - get the PORT_* attribut for that port.
> > + * @port: The port we want the information from
> > + *
> > + * Returns: A PORT_XXX value.
> > + */
> > +int phy_port_get_type(struct phy_port *port)
> > +{
> > + if (port->mediums & ETHTOOL_LINK_MEDIUM_BASET)
>
> Hi Maxime,
>
> Should this be:
>
> if (port->mediums & BIT(ETHTOOL_LINK_MEDIUM_BASET))
>
> Flagged by Smatch (because ETHTOOL_LINK_MEDIUM_BASET is 0,
> so as-is the condition is always false).
You're absolutely correct ! Thanks...
Maxime
Powered by blists - more mailing lists