linux-kernel - Re: [PATCH v2 1/2] dt-bindings: clock: qcom,videocc: Add sc8180x compatible

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <0323b9eb-9a3d-4d17-bad8-f9052fb30b57@kernel.org>
Date: Tue, 1 Jul 2025 15:27:37 +0200
From: Krzysztof Kozlowski <krzk@...nel.org>
To: Satya Priya Kakitapalli <quic_skakitap@...cinc.com>,
 Konrad Dybcio <konrad.dybcio@....qualcomm.com>,
 Bjorn Andersson <andersson@...nel.org>,
 Konrad Dybcio <konradybcio@...nel.org>, Rob Herring <robh@...nel.org>,
 Krzysztof Kozlowski <krzk+dt@...nel.org>, Conor Dooley
 <conor+dt@...nel.org>, Michael Turquette <mturquette@...libre.com>,
 Stephen Boyd <sboyd@...nel.org>
Cc: Ajit Pandey <quic_ajipan@...cinc.com>,
 Imran Shaik <quic_imrashai@...cinc.com>, Taniya Das <quic_tdas@...cinc.com>,
 Jagadeesh Kona <quic_jkona@...cinc.com>, linux-arm-msm@...r.kernel.org,
 devicetree@...r.kernel.org, linux-kernel@...r.kernel.org,
 linux-clk@...r.kernel.org
Subject: Re: [PATCH v2 1/2] dt-bindings: clock: qcom,videocc: Add sc8180x
 compatible

On 01/07/2025 14:09, Satya Priya Kakitapalli wrote:
> 
> On 7/1/2025 5:23 PM, Konrad Dybcio wrote:
>>
>> On 01-Jul-25 13:40, Satya Priya Kakitapalli wrote:
>>> The sc8180x video clock controller block is identical to that
>>> of sm8150. Add a new compatible string for sc8180x videocc and
>>> use sm8150 as fallback.
>>>
>>> Signed-off-by: Satya Priya Kakitapalli <quic_skakitap@...cinc.com>
>>> ---
>> The yaml checker throws a warning:
>>
>> make ARCH=arm64 LLVM=1 -j$(nproc) dt_binding_check DT_SCHEMA_FILES="Documentation/devicetree/bindings/clock/qcom,videocc.yaml"
>>
>>    CHKDT   ./Documentation/devicetree/bindings
>>    LINT    ./Documentation/devicetree/bindings
>> ./Documentation/devicetree/bindings/clock/qcom,videocc.yaml:28:9: [warning] wrong indentation: expected 10 but found 8 (indentation)
>> ./Documentation/devicetree/bindings/clock/qcom,videocc.yaml:35:9: [warning] wrong indentation: expected 10 but found 8 (indentation)
>>    DTEX    Documentation/devicetree/bindings/clock/qcom,videocc.example.dts
>>    DTC [C] Documentation/devicetree/bindings/clock/qcom,videocc.example.dtb
> 
> 
> I somehow didn't get these warning when I ran the DT checker.
> 
> I am able to reproduce these warnings by running the yamllint tool 
> directly, will fix them and resend, thanks.
> 
> 
> $ yamllint Documentation/devicetree/bindings/clock/qcom,videocc.yaml
>          Documentation/devicetree/bindings/clock/qcom,videocc.yaml
>                28:9      error    wrong indentation: expected 10 but 
> found 8  (indentation)
>                35:9      error    wrong indentation: expected 10 but 
> found 8  (indentation)
> 

Qualcomm needs to stop using Ubuntu 18.04 or 20.04 or whatever ancient
is there for development... These errors are part of standard check but
broken or crazy old system would explain why it does not work.

Plus you get huge speed up on new Python.

Best regards,
Krzysztof