linux-kernel - Re: [PATCH net-next v2] sfc: siena: eliminate xdp_rxq_info

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <cc3dd44a-b94a-4537-b68b-49a800acc935@gmail.com>
Date: Tue, 1 Jul 2025 14:38:30 +0100
From: Edward Cree <ecree.xilinx@...il.com>
To: Larysa Zaremba <larysa.zaremba@...el.com>,
 Fushuai Wang <wangfushuai@...du.com>
Cc: andrew+netdev@...n.ch, davem@...emloft.net, edumazet@...gle.com,
 kuba@...nel.org, pabeni@...hat.com, netdev@...r.kernel.org,
 linux-net-drivers@....com, linux-kernel@...r.kernel.org
Subject: Re: [PATCH net-next v2] sfc: siena: eliminate xdp_rxq_info_valid
 using XDP base API

On 01/07/2025 14:29, Larysa Zaremba wrote:
> On Sat, Jun 28, 2025 at 01:10:33PM +0800, Fushuai Wang wrote:
>> Commit d48523cb88e0 ("sfc: Copy shared files needed for Siena (part 2)")
>> use xdp_rxq_info_valid to track failures of xdp_rxq_info_reg().
>> However, this driver-maintained state becomes redundant since the XDP
>> framework already provides xdp_rxq_info_is_reg() for checking registration
>> status.
>>
>> Signed-off-by: Fushuai Wang <wangfushuai@...du.com>
> 
> You could have sent those patches in a single patchset, but the patches 
> themselves are fine.

I asked him to split it, for a few reasons (different blamed commits,
 clearer Subject: lines, Siena is EOL).
So if you don't like it, blame me ;-)

> Reviewed-by: Larysa Zaremba <larysa.zaremba@...el.com>