linux-kernel - Re: [PATCH v2 1/2] ACPI: Return -ENODEV from acpi_parse

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAJZ5v0h06-uQq57So7GzBMJ48dr42z3hY0EBFHSUmsjsVaUgjw@mail.gmail.com>
Date: Tue, 1 Jul 2025 15:54:09 +0200
From: "Rafael J. Wysocki" <rafael@...nel.org>
To: Catalin Marinas <catalin.marinas@....com>
Cc: Li Chen <me@...ux.beauty>, "Rafael J . Wysocki" <rafael@...nel.org>, 
	Hanjun Guo <guohanjun@...wei.com>, Will Deacon <will@...nel.org>, Len Brown <lenb@...nel.org>, 
	Liu Wei <liuwei09@...tc.cn>, Ryan Roberts <ryan.roberts@....com>, 
	Andrew Morton <akpm@...ux-foundation.org>, Jonathan Cameron <Jonathan.Cameron@...wei.com>, 
	Sudeep Holla <sudeep.holla@....com>, linux-arm-kernel@...ts.infradead.org, 
	linux-kernel@...r.kernel.org, linux-acpi@...r.kernel.org
Subject: Re: [PATCH v2 1/2] ACPI: Return -ENODEV from acpi_parse_spcr() when
 SPCR support is disabled

On Tue, Jul 1, 2025 at 1:53 PM Catalin Marinas <catalin.marinas@....com> wrote:
>
> On Fri, Jun 20, 2025 at 09:13:07PM +0800, Li Chen wrote:
> > From: Li Chen <chenl311@...natelecom.cn>
> >
> > If CONFIG_ACPI_SPCR_TABLE is disabled, acpi_parse_spcr()
> > currently returns 0, which may incorrectly suggest that
> > SPCR parsing was successful. This patch changes the behavior
> > to return -ENODEV to clearly indicate that SPCR support
> > is not available.
> >
> > This prepares the codebase for future changes that depend
> > on acpi_parse_spcr() failure detection, such as suppressing
> > misleading console messages.
> >
> > Signed-off-by: Li Chen <chenl311@...natelecom.cn>
> > ---
> >  include/linux/acpi.h | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/include/linux/acpi.h b/include/linux/acpi.h
> > index f102c0fe34318..71e692f952905 100644
> > --- a/include/linux/acpi.h
> > +++ b/include/linux/acpi.h
> > @@ -1503,7 +1503,7 @@ int acpi_parse_spcr(bool enable_earlycon, bool enable_console);
> >  #else
> >  static inline int acpi_parse_spcr(bool enable_earlycon, bool enable_console)
> >  {
> > -     return 0;
> > +     return -ENODEV;
> >  }
> >  #endif
>
> Rafael, are you ok with this patch going via the arm64 tree?

Yes, I am, thanks!