linux-kernel - Re: [PATCH] irqchip/qcom-irq-combiner: Rename driver struct to end in

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <fe166777-00bd-46a1-a971-46a513b6616c@oss.qualcomm.com>
Date: Tue, 1 Jul 2025 08:34:27 -0600
From: Jeff Hugo <jeff.hugo@....qualcomm.com>
To: Konrad Dybcio <konrad.dybcio@....qualcomm.com>,
        Uwe Kleine-König <u.kleine-koenig@...libre.com>,
        Marc Zyngier <maz@...nel.org>, Thomas Gleixner <tglx@...utronix.de>
Cc: linux-arm-msm@...r.kernel.org, linux-kernel@...r.kernel.org,
        Markus Schneider-Pargmann <msp@...libre.com>
Subject: Re: [PATCH] irqchip/qcom-irq-combiner: Rename driver struct to end in
 _driver

On 7/1/2025 1:40 AM, Konrad Dybcio wrote:
> 
> 
> On 30-Jun-25 20:31, Jeff Hugo wrote:
>> On 6/30/2025 11:25 AM, Konrad Dybcio wrote:
>>>
>>>
>>> On 30-Jun-25 19:23, Uwe Kleine-König wrote:
>>>> The modpost section mismatch checks are more lax for objects that have a
>>>> name that ends in "_probe". This is not justified here though, so rename
>>>> the driver struct according to the usual naming choice.
>>>>
>>>> Note that this change indeed results in modpost identifying a section
>>>> mismatch in this driver. This is not a false positive and should be
>>>> fixed by either converting the driver to use platform_driver_probe() or
>>>> by dropping __init from the .probe() callback. This problem was
>>>> introduced in commit f20cc9b00c7b ("irqchip/qcom: Add IRQ combiner
>>>> driver").
>>>>
>>>> Signed-off-by: Uwe Kleine-König <u.kleine-koenig@...libre.com>
>>>> ---
>>>> Hello,
>>>>
>>>> I don't know if platform_driver_probe() works here, it might happen that
>>>> the driver is probed before the matching device appears. As I don't have
>>>> a machine with such a device I won't create a patch fixing the issue,
>>>> but if you have questions don't hesitate to ask.
>>>>
>>>> Please consider this patch as a bug report and better only apply it when
>>>> the issue is addressed to not result in build regressions.
>>>
>>> +Jeff is probably the last person on Earth that officially has one
>>
>> We are talking about QDF2400 here?
> 
> Yes (or anything from the same family)

Ok.  Will take a look.

-Jeff