linux-kernel - Re: [PATCH] cxl: Include range.h in cxl.h

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <6863fcb649c0d_2ff1fe29428@iweiny-mobl.notmuch>
Date: Tue, 1 Jul 2025 10:20:22 -0500
From: Ira Weiny <ira.weiny@...el.com>
To: Nathan Chancellor <nathan@...nel.org>, Davidlohr Bueso
	<dave@...olabs.net>, Jonathan Cameron <jonathan.cameron@...wei.com>, "Dave
 Jiang" <dave.jiang@...el.com>, Alison Schofield <alison.schofield@...el.com>,
	Vishal Verma <vishal.l.verma@...el.com>, Ira Weiny <ira.weiny@...el.com>,
	"Dan Williams" <dan.j.williams@...el.com>, Andy Shevchenko
	<andriy.shevchenko@...ux.intel.com>
CC: <linux-cxl@...r.kernel.org>, <linux-kernel@...r.kernel.org>, "Nathan
 Chancellor" <nathan@...nel.org>
Subject: Re: [PATCH] cxl: Include range.h in cxl.h

Nathan Chancellor wrote:
> After commit aefeb286b960 ("libnvdimm: Don't use "proxy" headers"),
> range.h may not be implicitly included, resulting in a build error:

Dave J., I'll pick this up since the nvdimm change was pushed through
libnvdimm.

That said, I'm not seeing this issue.  What config caught this?

Ira

> 
>   In file included from drivers/cxl/core/features.c:8:
>   drivers/cxl/cxl.h:365:22: error: field 'hpa_range' has incomplete type
>     365 |         struct range hpa_range;
>         |                      ^~~~~~~~~
>   drivers/cxl/cxl.h:562:22: error: field 'hpa_range' has incomplete type
>     562 |         struct range hpa_range;
>         |                      ^~~~~~~~~
>   drivers/cxl/cxl.h:570:22: error: field 'hpa_range' has incomplete type
>     570 |         struct range hpa_range;
>         |                      ^~~~~~~~~
>   drivers/cxl/cxl.h:803:22: error: array type has incomplete element type 'struct range'
>     803 |         struct range dvsec_range[2];
>         |                      ^~~~~~~~~~~
> 
> Include range.h in cxl.h explicitly to clear up the errors.
> 
> Fixes: aefeb286b960 ("libnvdimm: Don't use "proxy" headers")
> Signed-off-by: Nathan Chancellor <nathan@...nel.org>
> ---
>  drivers/cxl/cxl.h | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/cxl/cxl.h b/drivers/cxl/cxl.h
> index 3f1695c96abc..b941ff94fe0a 100644
> --- a/drivers/cxl/cxl.h
> +++ b/drivers/cxl/cxl.h
> @@ -11,6 +11,7 @@
>  #include <linux/log2.h>
>  #include <linux/node.h>
>  #include <linux/io.h>
> +#include <linux/range.h>
>  
>  extern const struct nvdimm_security_ops *cxl_security_ops;
>  
> 
> ---
> base-commit: aefeb286b960a0629273d1dc809ea36754f42d98
> change-id: 20250701-cxl-fix-struct-range-error-8475cbbf3358
> 
> Best regards,
> --  
> Nathan Chancellor <nathan@...nel.org>
> 
>