linux-kernel - Re: [RFC PATCH v7 05/37] KVM: lapic: Change lapic regs base address to void pointer

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20250701154726.GJaGQDDjGGDNpuqhFF@fat_crate.local>
Date: Tue, 1 Jul 2025 17:47:26 +0200
From: Borislav Petkov <bp@...en8.de>
To: Neeraj Upadhyay <Neeraj.Upadhyay@....com>
Cc: linux-kernel@...r.kernel.org, tglx@...utronix.de, mingo@...hat.com,
	dave.hansen@...ux.intel.com, Thomas.Lendacky@....com,
	nikunj@....com, Santosh.Shukla@....com, Vasant.Hegde@....com,
	Suravee.Suthikulpanit@....com, David.Kaplan@....com, x86@...nel.org,
	hpa@...or.com, peterz@...radead.org, seanjc@...gle.com,
	pbonzini@...hat.com, kvm@...r.kernel.org,
	kirill.shutemov@...ux.intel.com, huibo.wang@....com,
	naveen.rao@....com, francescolavra.fl@...il.com,
	tiala@...rosoft.com
Subject: Re: [RFC PATCH v7 05/37] KVM: lapic: Change lapic regs base address
 to void pointer

On Tue, Jun 10, 2025 at 11:23:52PM +0530, Neeraj Upadhyay wrote:
> Change lapic regs base address from "char *" to "void *" in KVM
> lapic's set/reg helper functions. Pointer arithmetic for "void *"
> and "char *" operate identically. With "void *" there is less
> of a chance of doing the wrong thing, e.g. neglecting to cast and
> reading a byte instead of the desired apic reg size.

Please go through your commit messages and do

s/apic/APIC/g

s/reg/register/g in human-readable text. I know this is talking about code but
still - writing a commit message which reads like code is yucky.

And all those abbreviations. You have a mish-mash of all lower letters and all
caps and it reads weird.

Next patch too:

"... for use in Secure AVIC apic driver..." why not "APIC" as a real
abbreviation too?

"... to signify that it is part of apic api."

... as part of the APIC API.

And so on.

Thx.

-- 
Regards/Gruss,
    Boris.

https://people.kernel.org/tglx/notes-about-netiquette