Message-ID: <pndy0t76g7x.fsf@axis.com>
Date: Tue, 1 Jul 2025 18:14:26 +0200
From: Waqar Hameed <waqar.hameed@...s.com>
To: David Lechner <dlechner@...libre.com>
CC: Vignesh Raghavendra <vigneshr@...com>, Julien Panis <jpanis@...libre.com>,
	William Breathitt Gray <wbg@...nel.org>, Linus Walleij
	<linus.walleij@...aro.org>, Bartosz Golaszewski <brgl@...ev.pl>, Peter Rosin
	<peda@...ntia.se>, Jonathan Cameron <jic23@...nel.org>, Nuno
 Sá <nuno.sa@...log.com>, Andy Shevchenko <andy@...nel.org>,
	Cosmin Tanislav <cosmin.tanislav@...log.com>, Lars-Peter Clausen
	<lars@...afoo.de>, Michael Hennerich <Michael.Hennerich@...log.com>,
	"Matthias Brugger" <matthias.bgg@...il.com>, AngeloGioacchino Del Regno
	<angelogioacchino.delregno@...labora.com>, Matteo Martelli
	<matteomartelli3@...il.com>, Heiko Stuebner <heiko@...ech.de>, "Francesco
 Dolcini" <francesco@...cini.it>, João Paulo Gonçalves <jpaulo.silvagoncalves@...il.com>, Hugo Villeneuve
	<hvilleneuve@...onoff.com>, Subhajit Ghosh <subhajit.ghosh@...aklogic.com>,
	Mudit Sharma <muditsharma.info@...il.com>, Gerald Loacker
	<gerald.loacker@...fvision.net>, Song Qiang <songqiang1304521@...il.com>,
	"Crt Mori" <cmo@...exis.com>, Dmitry Torokhov <dmitry.torokhov@...il.com>,
	"Ulf Hansson" <ulf.hansson@...aro.org>, Karol Gugala <kgugala@...micro.com>,
	Mateusz Holenko <mholenko@...micro.com>, Gabriel Somlo <gsomlo@...il.com>,
	Joel Stanley <joel@....id.au>, Claudiu Manoil <claudiu.manoil@....com>,
	Vladimir Oltean <vladimir.oltean@....com>, Wei Fang <wei.fang@....com>, Clark
 Wang <xiaoning.wang@....com>, Andrew Lunn <andrew+netdev@...n.ch>, "David S.
 Miller" <davem@...emloft.net>, Eric Dumazet <edumazet@...gle.com>, Jakub
 Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>, Vinod Koul
	<vkoul@...nel.org>, Kishon Vijay Abraham I <kishon@...nel.org>, Krzysztof
 Kozlowski <krzk@...nel.org>, Alim Akhtar <alim.akhtar@...sung.com>, Sebastian
 Reichel <sre@...nel.org>, Uwe Kleine-König
	<ukleinek@...nel.org>, Neil Armstrong <neil.armstrong@...aro.org>, Kevin
 Hilman <khilman@...libre.com>, "Jerome Brunet" <jbrunet@...libre.com>, Martin
 Blumenstingl <martin.blumenstingl@...glemail.com>, Han Xu <han.xu@....com>,
	Haibo Chen <haibo.chen@....com>, Yogesh Gaur <yogeshgaur.83@...il.com>, Mark
 Brown <broonie@...nel.org>, Avri Altman <avri.altman@....com>, Bart Van
 Assche <bvanassche@....org>, "James E.J. Bottomley"
	<James.Bottomley@...senPartnership.com>, "Martin K. Petersen"
	<martin.petersen@...cle.com>, Souradeep Chowdhury
	<quic_schowdhu@...cinc.com>, Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	Liam Girdwood <lgirdwood@...il.com>, Peter Ujfalusi
	<peter.ujfalusi@...ux.intel.com>, Bard Liao
	<yung-chuan.liao@...ux.intel.com>, Ranjani Sridharan
	<ranjani.sridharan@...ux.intel.com>, Daniel Baluta <daniel.baluta@....com>,
	Kai Vehmanen <kai.vehmanen@...ux.intel.com>, Pierre-Louis Bossart
	<pierre-louis.bossart@...ux.dev>, Jaroslav Kysela <perex@...ex.cz>, "Takashi
 Iwai" <tiwai@...e.com>, Shawn Guo <shawnguo@...nel.org>, Sascha Hauer
	<s.hauer@...gutronix.de>, Pengutronix Kernel Team <kernel@...gutronix.de>,
	Fabio Estevam <festevam@...il.com>, <kernel@...s.com>,
	<linux-iio@...r.kernel.org>, <linux-omap@...r.kernel.org>,
	<linux-kernel@...r.kernel.org>, <linux-gpio@...r.kernel.org>,
	<linux-i2c@...r.kernel.org>, <linux-arm-kernel@...ts.infradead.org>,
	<linux-mediatek@...ts.infradead.org>, <linux-rockchip@...ts.infradead.org>,
	<linux-input@...r.kernel.org>, <linux-mmc@...r.kernel.org>,
	<imx@...ts.linux.dev>, <netdev@...r.kernel.org>,
	<linux-phy@...ts.infradead.org>, <linux-samsung-soc@...r.kernel.org>,
	<linux-pm@...r.kernel.org>, <linux-pwm@...r.kernel.org>,
	<linux-amlogic@...ts.infradead.org>, <linux-spi@...r.kernel.org>,
	<linux-scsi@...r.kernel.org>, <linux-arm-msm@...r.kernel.org>,
	<linux-usb@...r.kernel.org>, <sound-open-firmware@...a-project.org>,
	<linux-sound@...r.kernel.org>
Subject: Re: [PATCH] Remove error prints for devm_add_action_or_reset()

On Tue, Jul 01, 2025 at 10:16 -0500 David Lechner <dlechner@...libre.com> wrote:

> On 7/1/25 10:03 AM, Waqar Hameed wrote:
>> When `devm_add_action_or_reset()` fails, it is due to a failed memory
>> allocation and will thus return `-ENOMEM`. `dev_err_probe()` doesn't do
>> anything when error is `-ENOMEM`. Therefore, remove the useless call to
>> `dev_err_probe()` when `devm_add_action_or_reset()` fails, and just
>> return the value instead.
>> 
>> Signed-off-by: Waqar Hameed <waqar.hameed@...s.com>
>> ---
> I can't speak for all subsystems, but this would probably be acceptable
> in the iio subsystem.
>
> However, I don't think anyone is going to accept a patch that touches
> all of these files at the same time across subsystems.
>
> So I would suggest to split this up into one patch per driver and create
> one series per subsystem. This way, each subsystem isn't bothered by unrelated
> patches that they don't particularly need to care about. And note that some
> subsystems like net have additional expectations, e.g for the patch subject
> so that it gets picked up by automated tools, so be sure to check the docs
> for this.

Thanks for the suggestion David! I will do that then.

(I was contemplating on doing that at first, but gambled on this, since
I saw some other commits patches touching multiple files in different
sub-systems.)

Powered by blists - more mailing lists