linux-kernel - Re: [PATCH v2] iio: imu: inv_mpu6050: Replace scnprintf with sysfs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID:
 <FR3P281MB1757C8DF7E1968A6F00C9E99CE41A@FR3P281MB1757.DEUP281.PROD.OUTLOOK.COM>
Date: Tue, 1 Jul 2025 16:19:51 +0000
From: Jean-Baptiste Maneyrol <Jean-Baptiste.Maneyrol@....com>
To: Chelsy Ratnawat <chelsyratnawat2001@...il.com>,
        "jic23@...nel.org"
	<jic23@...nel.org>
CC: "dlechner@...libre.com" <dlechner@...libre.com>,
        "nuno.sa@...log.com"
	<nuno.sa@...log.com>,
        "andy@...nel.org" <andy@...nel.org>,
        "linux-iio@...r.kernel.org" <linux-iio@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v2] iio: imu: inv_mpu6050: Replace scnprintf with
 sysfs_emit

>
>________________________________________
>From: Chelsy Ratnawat <chelsyratnawat2001@...il.com>
>Sent: Tuesday, July 1, 2025 17:47
>To: Jean-Baptiste Maneyrol <Jean-Baptiste.Maneyrol@....com>; jic23@...nel.org <jic23@...nel.org>
>Cc: dlechner@...libre.com <dlechner@...libre.com>; nuno.sa@...log.com <nuno.sa@...log.com>; andy@...nel.org <andy@...nel.org>; linux-iio@...r.kernel.org <linux-iio@...r.kernel.org>; linux-kernel@...r.kernel.org <linux-kernel@...r.kernel.org>; Chelsy Ratnawat <chelsyratnawat2001@...il.com>
>Subject: [PATCH v2] iio: imu: inv_mpu6050: Replace scnprintf with sysfs_emit
> 
>This Message Is From an External Sender
>This message came from outside your organization.
> 
>Documentation/filesystems/sysfs.rst mentions that show() should only
>use sysfs_emit() or sysfs_emit_at() when formating the value to be
>returned to user space. So replace scnprintf() with sysfs_emit().
>
>Signed-off-by: Chelsy Ratnawat <chelsyratnawat2001@...il.com>
>---
> drivers/iio/imu/inv_mpu6050/inv_mpu_core.c | 5 ++---
> 1 file changed, 2 insertions(+), 3 deletions(-)
>
>diff --git a/drivers/iio/imu/inv_mpu6050/inv_mpu_core.c b/drivers/iio/imu/inv_mpu6050/inv_mpu_core.c
>index b8656c02354a..39eb516acc73 100644
>--- a/drivers/iio/imu/inv_mpu6050/inv_mpu_core.c
>+++ b/drivers/iio/imu/inv_mpu6050/inv_mpu_core.c
>@@ -1382,7 +1382,7 @@ inv_fifo_rate_show(struct device *dev, struct device_attribute *attr,
> 	fifo_rate = INV_MPU6050_DIVIDER_TO_FIFO_RATE(st->chip_config.divider);
> 	mutex_unlock(&st->lock);
> 
>-	return scnprintf(buf, PAGE_SIZE, "%u\n", fifo_rate);
>+	return sysfs_emit(buf, "%u\n", fifo_rate);
> }
> 
> /*
>@@ -1409,8 +1409,7 @@ static ssize_t inv_attr_show(struct device *dev, struct device_attribute *attr,
> 	case ATTR_ACCL_MATRIX:
> 		m = st->plat_data.orientation;
> 
>-		return scnprintf(buf, PAGE_SIZE,
>-			"%d, %d, %d; %d, %d, %d; %d, %d, %d\n",
>+		return sysfs_emit(buf, "%d, %d, %d; %d, %d, %d; %d, %d, %d\n",
> 			m[0], m[1], m[2], m[3], m[4], m[5], m[6], m[7], m[8]);
> 	default:
> 		return -EINVAL;
>-- 
>2.47.1
>
>

Hello Chelsy,

thanks for the patch, it is all good for me.

Acked-by: Jean-Baptiste Maneyrol <jean-baptiste.maneyrol@....com>

Thanks,
JB