linux-kernel - Re: [PATCH] PCI: dwc: Make dw_pcie_ptm

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20250701163910.GA1838835@bhelgaas>
Date: Tue, 1 Jul 2025 11:39:10 -0500
From: Bjorn Helgaas <helgaas@...nel.org>
To: Manivannan Sadhasivam <mani@...nel.org>
Cc: lpieralisi@...nel.org, jingoohan1@...il.com, kwilczynski@...nel.org,
	bhelgaas@...gle.com, robh@...nel.org, linux-pci@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] PCI: dwc: Make dw_pcie_ptm_ops static

On Tue, Jul 01, 2025 at 05:38:56PM +0530, Manivannan Sadhasivam wrote:
> dw_pcie_ptm_ops is not used outside of this file, so make it static. This
> also fixes the sparse warning:
> 
>   drivers/pci/controller/dwc/pcie-designware-debugfs.c:868:27: warning: symbol 'dw_pcie_ptm_ops' was not declared. Should it be static?
> 
> Fixes: 852a1fdd34a8 ("PCI: dwc: Add debugfs support for PTM context")
> Reported-by: Bjorn Helgaas <helgaas@...nel.org>
> Closes: https://lore.kernel.org/linux-pci/20250617231210.GA1172093@bhelgaas
> Signed-off-by: Manivannan Sadhasivam <mani@...nel.org>

Thanks, looks good to me.

> ---
>  drivers/pci/controller/dwc/pcie-designware-debugfs.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/pci/controller/dwc/pcie-designware-debugfs.c b/drivers/pci/controller/dwc/pcie-designware-debugfs.c
> index c67601096c48..7356b0f6a2ad 100644
> --- a/drivers/pci/controller/dwc/pcie-designware-debugfs.c
> +++ b/drivers/pci/controller/dwc/pcie-designware-debugfs.c
> @@ -865,7 +865,7 @@ static bool dw_pcie_ptm_t4_visible(void *drvdata)
>  	return (pci->mode == DW_PCIE_EP_TYPE) ? true : false;
>  }
>  
> -const struct pcie_ptm_ops dw_pcie_ptm_ops = {
> +static const struct pcie_ptm_ops dw_pcie_ptm_ops = {
>  	.check_capability = dw_pcie_ptm_check_capability,
>  	.context_update_write = dw_pcie_ptm_context_update_write,
>  	.context_update_read = dw_pcie_ptm_context_update_read,
> -- 
> 2.45.2
>