linux-kernel - Re: [PATCH v4 0/6] replace `allow(...)` lints with `expect(...)`

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20250701202752.4f3eacc9@nimda.home>
Date: Tue, 1 Jul 2025 20:27:52 +0300
From: Onur <work@...rozkan.dev>
To: Miguel Ojeda <miguel.ojeda.sandonis@...il.com>
Cc: rust-for-linux@...r.kernel.org, linux-kernel@...r.kernel.org,
 linux-pm@...r.kernel.org, linux-kselftest@...r.kernel.org,
 kunit-dev@...glegroups.com, airlied@...il.com, simona@...ll.ch,
 ojeda@...nel.org, alex.gaynor@...il.com, boqun.feng@...il.com,
 gary@...yguo.net, bjorn3_gh@...tonmail.com, lossin@...nel.org,
 a.hindborg@...nel.org, aliceryhl@...gle.com, tmgross@...ch.edu,
 rafael@...nel.org, viresh.kumar@...aro.org, gregkh@...uxfoundation.org,
 maarten.lankhorst@...ux.intel.com, mripard@...nel.org, tzimmermann@...e.de,
 davidgow@...gle.com, nm@...com
Subject: Re: [PATCH v4 0/6] replace `allow(...)` lints with `expect(...)`

On Tue, 1 Jul 2025 10:43:10 +0200
Miguel Ojeda <miguel.ojeda.sandonis@...il.com> wrote:

> On Tue, Jul 1, 2025 at 7:36 AM Onur Özkan <work@...rozkan.dev> wrote:
> >
> > Onur Özkan (6):
> >   rust: switch to `#[expect(...)]` in core modules
> >   rust: switch to `#[expect(...)]` in init and kunit
> >   drivers: gpu: switch to `#[expect(...)]` in nova-core/regs.rs
> >   rust: switch to `#[expect(...)]` in devres, driver and ioctl
> >   rust: remove `#[allow(clippy::unnecessary_cast)]`
> >   rust: remove `#[allow(clippy::non_send_fields_in_send_ty)]`
> 
> Thanks for splitting this, it is very much appreciated.
> 
> I think you decided on a split based on similarity (?). In the kernel,
> different maintainers/trees take care of different areas/files (the
> `MAINTAINERS` file describes this mapping). For instance, in one of
> them, KUnit and init is mixed, which are maintained by different
> people.

I didn't know I could use `MAINTAINERS` file to organize my changes.

> That is why the split I suggested was one that allows maintainers to
> pick them independently. With this one, maintainers still have to
> coordinate, which isn't a big deal, since the changes are small and
> straightforward, but the purpose of the split was to avoid that.


I see, I will make sure to use `MAINTAINERS` file as a ref next
time, thank you. :)

Regards,
Onur