linux-kernel - Re: [PATCH] fpga: dfl: Replace scnprintf() with sysfs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <202507011110.nJmYZDdm-lkp@intel.com>
Date: Tue, 1 Jul 2025 12:09:45 +0800
From: kernel test robot <lkp@...el.com>
To: Ryan Chung <seokwoo.chung130@...il.com>, hao.wu@...el.com,
	trix@...hat.com, mdf@...nel.org, yilun.xu@...el.com
Cc: llvm@...ts.linux.dev, oe-kbuild-all@...ts.linux.dev,
	linux-fpga@...r.kernel.org, linux-kernel-mentees@...ts.linux.dev,
	linux-kernel@...r.kernel.org,
	Ryan Chung <seokwoo.chung130@...il.com>
Subject: Re: [PATCH] fpga: dfl: Replace scnprintf() with sysfs_emit()

Hi Ryan,

kernel test robot noticed the following build errors:

[auto build test ERROR on linus/master]
[also build test ERROR on v6.16-rc4 next-20250630]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]

url:    https://github.com/intel-lab-lkp/linux/commits/Ryan-Chung/fpga-dfl-Replace-scnprintf-with-sysfs_emit/20250630-205221
base:   linus/master
patch link:    https://lore.kernel.org/r/20250630125018.48417-1-seokwoo.chung130%40gmail.com
patch subject: [PATCH] fpga: dfl: Replace scnprintf() with sysfs_emit()
config: i386-randconfig-011-20250701 (https://download.01.org/0day-ci/archive/20250701/202507011110.nJmYZDdm-lkp@intel.com/config)
compiler: clang version 20.1.7 (https://github.com/llvm/llvm-project 6146a88f60492b520a36f8f8f3231e15f3cc6082)
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20250701/202507011110.nJmYZDdm-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@...el.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202507011110.nJmYZDdm-lkp@intel.com/

All errors (new ones prefixed by >>):

>> drivers/fpga/dfl-afu-main.c:159:25: error: incompatible integer to pointer conversion passing 'unsigned long' to parameter of type 'const char *' [-Wint-conversion]
     159 |         return sysfs_emit(buf, PAGE_SIZE, "%d\n", id);
         |                                ^~~~~~~~~
   include/vdso/page.h:15:19: note: expanded from macro 'PAGE_SIZE'
      15 | #define PAGE_SIZE       (_AC(1,UL) << CONFIG_PAGE_SHIFT)
         |                         ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
   include/linux/sysfs.h:492:39: note: passing argument to parameter 'fmt' here
     492 | int sysfs_emit(char *buf, const char *fmt, ...);
         |                                       ^
   drivers/fpga/dfl-afu-main.c:478:25: error: incompatible integer to pointer conversion passing 'unsigned long' to parameter of type 'const char *' [-Wint-conversion]
     478 |         return sysfs_emit(buf, PAGE_SIZE, "%016llx%016llx\n", guidh, guidl);
         |                                ^~~~~~~~~
   include/vdso/page.h:15:19: note: expanded from macro 'PAGE_SIZE'
      15 | #define PAGE_SIZE       (_AC(1,UL) << CONFIG_PAGE_SHIFT)
         |                         ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
   include/linux/sysfs.h:492:39: note: passing argument to parameter 'fmt' here
     492 | int sysfs_emit(char *buf, const char *fmt, ...);
         |                                       ^
   2 errors generated.


vim +159 drivers/fpga/dfl-afu-main.c

   152	
   153	static ssize_t
   154	id_show(struct device *dev, struct device_attribute *attr, char *buf)
   155	{
   156		struct dfl_feature_dev_data *fdata = to_dfl_feature_dev_data(dev);
   157		int id = port_get_id(fdata);
   158	
 > 159		return sysfs_emit(buf, PAGE_SIZE, "%d\n", id);
   160	}
   161	static DEVICE_ATTR_RO(id);
   162	

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki