linux-kernel - Re: [PATCH] drm/amd/pm/powerplay/hwmgr/smu

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CADnq5_PRBcOb+9To8ax4ardU9rBOAbEch7qegTxErpUGm7rW+w@mail.gmail.com>
Date: Tue, 1 Jul 2025 14:49:48 -0400
From: Alex Deucher <alexdeucher@...il.com>
To: Fedor Pchelkin <pchelkin@...ras.ru>
Cc: Kenneth Feng <kenneth.feng@....com>, Alex Deucher <alexander.deucher@....com>, 
	Christian König <christian.koenig@....com>, 
	Rex Zhu <Rex.Zhu@....com>, Jammy Zhou <Jammy.Zhou@....com>, amd-gfx@...ts.freedesktop.org, 
	dri-devel@...ts.freedesktop.org, linux-kernel@...r.kernel.org, 
	lvc-project@...uxtesting.org
Subject: Re: [PATCH] drm/amd/pm/powerplay/hwmgr/smu_helper: fix order of mask
 and value

Applied.

Alex

On Mon, Jun 30, 2025 at 4:33 PM Fedor Pchelkin <pchelkin@...ras.ru> wrote:
>
> There is a small typo in phm_wait_on_indirect_register().
>
> Swap mask and value arguments provided to phm_wait_on_register() so that
> they satisfy the function signature and actual usage scheme.
>
> Found by Linux Verification Center (linuxtesting.org) with Svace static
> analysis tool.
>
> Fixes: 3bace3591493 ("drm/amd/powerplay: add hardware manager sub-component")
> Signed-off-by: Fedor Pchelkin <pchelkin@...ras.ru>
> ---
>  drivers/gpu/drm/amd/pm/powerplay/hwmgr/smu_helper.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/amd/pm/powerplay/hwmgr/smu_helper.c b/drivers/gpu/drm/amd/pm/powerplay/hwmgr/smu_helper.c
> index 79a566f3564a..c305ea4ec17d 100644
> --- a/drivers/gpu/drm/amd/pm/powerplay/hwmgr/smu_helper.c
> +++ b/drivers/gpu/drm/amd/pm/powerplay/hwmgr/smu_helper.c
> @@ -149,7 +149,7 @@ int phm_wait_on_indirect_register(struct pp_hwmgr *hwmgr,
>         }
>
>         cgs_write_register(hwmgr->device, indirect_port, index);
> -       return phm_wait_on_register(hwmgr, indirect_port + 1, mask, value);
> +       return phm_wait_on_register(hwmgr, indirect_port + 1, value, mask);
>  }
>
>  int phm_wait_for_register_unequal(struct pp_hwmgr *hwmgr,
> --
> 2.50.0
>