linux-kernel - Re: [PATCH] pinctrl: rp1: silence uninitialized variable warning

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <496f817d-802a-4889-a7dd-155d51895d16@suswa.mountain>
Date: Tue, 1 Jul 2025 22:04:10 +0300
From: Dan Carpenter <dan.carpenter@...aro.org>
To: Andrea della Porta <andrea.porta@...e.com>
Cc: Linus Walleij <linus.walleij@...aro.org>, linux-gpio@...r.kernel.org,
	linux-kernel@...r.kernel.org, kernel-janitors@...r.kernel.org
Subject: Re: [PATCH] pinctrl: rp1: silence uninitialized variable warning

On Tue, Jul 01, 2025 at 11:30:01AM +0200, Andrea della Porta wrote:
> We really can't get rid of that warning by replacing ENOTSUPP with
> EOPNOTSUPP because the core pinctrl code still rely on the 'wrong'
> define

Ah good.  Thanks for the explanation.  I'm glad I didn't try "fix" it
then.  :)

> like this excerpt from drivers/pinctrl/pinconf-generic.c:
> 
> ...
> 	if (gname)
> 		ret = pin_config_group_get(dev_name(pctldev->dev),
> 					   gname, &config);
> 	else
> 		ret = pin_config_get_for_pin(pctldev, pin, &config);
> 	/* These are legal errors */
> 	if (ret == -EINVAL || ret == -ENOTSUPP)
> 		continue;
> ...
> 
> Also, many drivers still rely on ENOTSUPP. Maybe a patch that will
> fix all of them at once (drivers and core code) is in order, I have
> it in my todo list, indeed.
> Besides that,
> 
> Reviewed-by: Andrea della Porta <andrea.porta@...e.com>

Thanks!

regards,
dan carpenter