linux-kernel - Re: [PATCH V6 0/7] Scheduler time slice extension

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <94190673-8978-4bcb-9755-bed718fa99ee@amd.com>
Date: Tue, 1 Jul 2025 10:00:56 +0530
From: K Prateek Nayak <kprateek.nayak@....com>
To: Prakash Sangappa <prakash.sangappa@...cle.com>,
 linux-kernel@...r.kernel.org
Cc: peterz@...radead.org, rostedt@...dmis.org,
 mathieu.desnoyers@...icios.com, tglx@...utronix.de, bigeasy@...utronix.de,
 vineethr@...ux.ibm.com
Subject: Re: [PATCH V6 0/7] Scheduler time slice extension

Hello Prakash,

On 7/1/2025 6:07 AM, Prakash Sangappa wrote:
> Prakash Sangappa (7):
>    Sched: Scheduler time slice extension
>    Sched: Indicate if thread got rescheduled
>    Sched: Tunable to specify duration of time slice extension
>    Sched: Add scheduler stat for cpu time slice extension
>    Sched: Add tracepoint for sched time slice extension
>    Add API to query supported rseq cs flags
>    Introduce a config option for scheduler time slice extension feature

nit.

IMO, the ordering of these patches can be improved. Introduction of
CONFIG_SCHED_PREEMPT_DELAY can come first followed by incrementally
adding the scheduler bits, followed by "rseq: Add API to query supported
rseq cs flags" and then finally introduce the bits that introduces
"RSEQ_CS_FLAG_DELAY_RESCHED" and allows the user to set.

This way all the CONFIG_SCHED_PREEMPT_DELAY can live in one place and
make it easier to review the entire series.

-- 
Thanks and Regards,
Prateek