linux-kernel - Re: [PATCH v2 2/3] dt-bindings: hwmon: Add Microchip EMC2101 support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <175139843060.2356328.5526096489625404757.robh@kernel.org>
Date: Tue, 01 Jul 2025 14:33:50 -0500
From: "Rob Herring (Arm)" <robh@...nel.org>
To: Álvaro Fernández Rojas <noltari@...il.com>
Cc: devicetree@...r.kernel.org, linux-kernel@...r.kernel.org, 
 krzk+dt@...nel.org, linux-doc@...r.kernel.org, conor+dt@...nel.org, 
 linux-hwmon@...r.kernel.org, jdelvare@...e.com, linux@...ck-us.net, 
 corbet@....net
Subject: Re: [PATCH v2 2/3] dt-bindings: hwmon: Add Microchip EMC2101
 support


On Tue, 01 Jul 2025 20:12:27 +0200, Álvaro Fernández Rojas wrote:
> Introduce yaml schema for Microchip emc2101 pwm fan controller with
> temperature monitoring.
> 
> Signed-off-by: Álvaro Fernández Rojas <noltari@...il.com>
> ---
>  .../bindings/hwmon/microchip,emc2101.yaml     | 79 +++++++++++++++++++
>  1 file changed, 79 insertions(+)
>  create mode 100644 Documentation/devicetree/bindings/hwmon/microchip,emc2101.yaml
> 
>  v2: add missing properties.
> 

My bot found errors running 'make dt_binding_check' on your patch:

yamllint warnings/errors:

dtschema/dtc warnings/errors:
/builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/hwmon/microchip,emc2101.yaml: patternProperties: '^fan@0$' should not be valid under {'pattern': '^\\^[a-zA-Z0-9,\\-._#@]+\\$$'}
	hint: Fixed strings belong in 'properties', not 'patternProperties'
	from schema $id: http://devicetree.org/meta-schemas/keywords.yaml#

doc reference errors (make refcheckdocs):

See https://patchwork.ozlabs.org/project/devicetree-bindings/patch/20250701181228.1196102-3-noltari@gmail.com

The base for the series is generally the latest rc1. A different dependency
should be noted in *this* patch.

If you already ran 'make dt_binding_check' and didn't see the above
error(s), then make sure 'yamllint' is installed and dt-schema is up to
date:

pip3 install dtschema --upgrade

Please check and re-submit after running the above command yourself. Note
that DT_SCHEMA_FILES can be set to your schema file to speed up checking
your schema. However, it must be unset to test all examples with your schema.