linux-kernel - Re: [PATCH] rust: acpi: remove unneeded cast to clean future Clippy warning

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <DB11L7KWH27S.8L9WLRAR1B0P@umich.edu>
Date: Tue, 01 Jul 2025 16:38:56 -0500
From: "Trevor Gross" <tmgross@...ch.edu>
To: "Miguel Ojeda" <ojeda@...nel.org>, "Rafael J. Wysocki"
 <rafael@...nel.org>, "Greg Kroah-Hartman" <gregkh@...uxfoundation.org>,
 "Danilo Krummrich" <dakr@...nel.org>, "Alex Gaynor" <alex.gaynor@...il.com>
Cc: "Len Brown" <lenb@...nel.org>, <linux-acpi@...r.kernel.org>, "Boqun
 Feng" <boqun.feng@...il.com>, "Gary Guo" <gary@...yguo.net>,
 Björn Roy Baron <bjorn3_gh@...tonmail.com>, "Benno Lossin"
 <lossin@...nel.org>, "Andreas Hindborg" <a.hindborg@...nel.org>, "Alice
 Ryhl" <aliceryhl@...gle.com>, <rust-for-linux@...r.kernel.org>,
 <linux-kernel@...r.kernel.org>, <patches@...ts.linux.dev>
Subject: Re: [PATCH] rust: acpi: remove unneeded cast to clean future Clippy
 warning

On Tue Jul 1, 2025 at 12:46 PM CDT, Miguel Ojeda wrote:
> A future Clippy warning, `clippy::as_underscore`, is getting enabled in
> parallel in the rust-next tree:
>
>     error: using `as _` conversion
>       --> rust/kernel/acpi.rs:25:9
>        |
>     25 |         self.0.driver_data as _
>        |         ^^^^^^^^^^^^^^^^^^^^^^-
>        |                               |
>        |                               help: consider giving the type explicitly: `usize`
>
> The type is already `ulong`, which nowadays is always `usize`, so the
> cast is unneeded. Thus remove it, which in turn will avoid the warning
> in the future.
>
> Other abstractions of device tables do not use a cast here either.
>
> Signed-off-by: Miguel Ojeda <ojeda@...nel.org>

Reviewed-by: Trevor Gross <tmgross@...ch.edu>