linux-kernel - Re: [PATCH v2] pch_uart: Fix dma_sync_sg_for

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <11c0c230-7a19-460c-99cb-18caf62aaedc@kernel.org>
Date: Tue, 1 Jul 2025 07:15:08 +0200
From: Jiri Slaby <jirislaby@...nel.org>
To: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
Cc: Thomas Fourier <fourier.thomas@...il.com>,
 Tomoya MORINAGA <tomoya-linux@....okisemi.com>,
 linux-kernel@...r.kernel.org, linux-serial@...r.kernel.org
Subject: Re: [PATCH v2] pch_uart: Fix dma_sync_sg_for_device() nents value

On 30. 06. 25, 15:13, Andy Shevchenko wrote:
> On Mon, Jun 30, 2025 at 03:01:01PM +0200, Jiri Slaby wrote:
>> On 30. 06. 25, 14:10, Thomas Fourier wrote:
>>> The dma_sync_sg_for_device() functions should be called with the same
>>> nents as the dma_map_sg(), not the value the map function returned.
>>
>> Care to explain why do you intend to sync more than mapped? "should be
>> called" is way to vague.
> 
> It's documented as the correct use of the DMA streaming API.
> Should we go deeper and understand why?

That's IMO enough if he put/referenced this in the commit log...

-- 
js
suse labs