linux-kernel - Re: [PATCH v5 23/23] perf sort: Use perf_env to set arch sort keys and header

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <aGN-9079q9sQaW8s@google.com>
Date: Mon, 30 Jun 2025 23:23:51 -0700
From: Namhyung Kim <namhyung@...nel.org>
To: Ian Rogers <irogers@...gle.com>
Cc: Peter Zijlstra <peterz@...radead.org>, Ingo Molnar <mingo@...hat.com>,
	Arnaldo Carvalho de Melo <acme@...nel.org>,
	Mark Rutland <mark.rutland@....com>,
	Alexander Shishkin <alexander.shishkin@...ux.intel.com>,
	Jiri Olsa <jolsa@...nel.org>,
	Adrian Hunter <adrian.hunter@...el.com>,
	Kan Liang <kan.liang@...ux.intel.com>,
	John Garry <john.g.garry@...cle.com>, Will Deacon <will@...nel.org>,
	James Clark <james.clark@...aro.org>,
	Mike Leach <mike.leach@...aro.org>, Leo Yan <leo.yan@...ux.dev>,
	"Masami Hiramatsu (Google)" <mhiramat@...nel.org>,
	Ravi Bangoria <ravi.bangoria@....com>,
	Charlie Jenkins <charlie@...osinc.com>,
	Colin Ian King <colin.i.king@...il.com>,
	Andi Kleen <ak@...ux.intel.com>, Dmitry Vyukov <dvyukov@...gle.com>,
	Graham Woodward <graham.woodward@....com>,
	Ilkka Koskinen <ilkka@...amperecomputing.com>,
	Zhongqiu Han <quic_zhonhan@...cinc.com>,
	Yicong Yang <yangyicong@...ilicon.com>,
	Athira Rajeev <atrajeev@...ux.ibm.com>,
	Kajol Jain <kjain@...ux.ibm.com>, Li Huafei <lihuafei1@...wei.com>,
	"Steinar H. Gunderson" <sesse@...gle.com>,
	Stephen Brennan <stephen.s.brennan@...cle.com>,
	Chun-Tse Shao <ctshao@...gle.com>, Yujie Liu <yujie.liu@...el.com>,
	"Dr. David Alan Gilbert" <linux@...blig.org>,
	Levi Yun <yeoreum.yun@....com>, Howard Chu <howardchu95@...il.com>,
	Weilin Wang <weilin.wang@...el.com>,
	Thomas Falcon <thomas.falcon@...el.com>,
	Matt Fleming <matt@...dmodwrite.com>,
	Veronika Molnarova <vmolnaro@...hat.com>,
	Krzysztof Łopatowski <krzysztof.m.lopatowski@...il.com>,
	Zixian Cai <fzczx123@...il.com>,
	Steve Clevenger <scclevenger@...amperecomputing.com>,
	Ben Gainey <ben.gainey@....com>,
	Chaitanya S Prakash <chaitanyas.prakash@....com>,
	Martin Liska <martin.liska@....com>,
	Martin Liška <m.liska@...link.cz>,
	Song Liu <song@...nel.org>, linux-kernel@...r.kernel.org,
	linux-perf-users@...r.kernel.org,
	linux-arm-kernel@...ts.infradead.org
Subject: Re: [PATCH v5 23/23] perf sort: Use perf_env to set arch sort keys
 and header

On Fri, Jun 27, 2025 at 09:50:17PM -0700, Ian Rogers wrote:
> Previously arch_support_sort_key and arch_perf_header_entry used a
> weak symbol to compile as appropriate for x86 and powerpc. A
> limitation to this is that the handling of a data file could vary in
> cross-platform development. Change to using the perf_env of the
> current session to determine the architecture kind and set the sort
> key and header entries as appropriate.
> 
> Signed-off-by: Ian Rogers <irogers@...gle.com>
> ---
[SNIP]
> diff --git a/tools/perf/builtin-report.c b/tools/perf/builtin-report.c
> index ada8e0166c78..6f24540bdee9 100644
> --- a/tools/perf/builtin-report.c
> +++ b/tools/perf/builtin-report.c
> @@ -1790,7 +1790,7 @@ int cmd_report(int argc, const char **argv)
>  	}
>  
>  	if ((last_key != K_SWITCH_INPUT_DATA && last_key != K_RELOAD) &&
> -	    (setup_sorting(session->evlist) < 0)) {
> +	    (setup_sorting(session->evlist, &session->header.env) < 0)) {

					    perf_session__env(session) ?

Thanks,
Namhyung


>  		if (sort_order)
>  			parse_options_usage(report_usage, options, "s", 1);
>  		if (field_order)