linux-kernel - RE: [PATCH 1/1] spi: cadence-quadspi: fix cleanup of rx

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID:
 <DM6PR03MB5017D9C650820B9A5C63C6ACC641A@DM6PR03MB5017.namprd03.prod.outlook.com>
Date: Tue, 1 Jul 2025 00:39:24 +0000
From: "Romli, Khairul Anuar" <khairul.anuar.romli@...era.com>
To: Dan Carpenter <dan.carpenter@...aro.org>
CC: Mark Brown <broonie@...nel.org>, "open list:SPI SUBSYSTEM"
	<linux-spi@...r.kernel.org>, open list <linux-kernel@...r.kernel.org>,
	"Gerlach, Matthew" <matthew.gerlach@...era.com>
Subject: RE: [PATCH 1/1] spi: cadence-quadspi: fix cleanup of rx_chan on
 failure paths

> On Mon, Jun 30, 2025 at 05:11:56PM +0800,
> khairul.anuar.romli@...era.com wrote:
> > From: Khairul Anuar Romli <khairul.anuar.romli@...era.com>
> >
> > Remove incorrect checks on cqspi->rx_chan that cause driver breakage
> > during failure cleanup. Ensure proper resource freeing on the success
> > path when operating in cqspi->use_direct_mode, preventing leaks and
> > improving stability.
> >
> > Signed-off-by: Khairul Anuar Romli <khairul.anuar.romli@...era.com>
> 
> Thanks.
> 
> Reviewed-by: Dan Carpenter <dan.carpenter@...aro.org>
> 
> Mark asked me to fix this and I wrote a fix but apparently I didn't hit send
> because it's still in my outbox.  Sorry about that.  :(
> 
> regards,
> dan carpenter

Sorry for sending the fix on your behalf.