linux-kernel - Re: [PATCH] Replace the use of scnprintf() with sysfs_emit_at() in several show functions to format the output into the sysfs buffer.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <aGOEOu7-oh1Nb9mm@nuc>
Date: Tue, 1 Jul 2025 08:46:18 +0200
From: Johannes Thumshirn <jth@...nel.org>
To: herculoxz <abhinav.ogl@...il.com>
Cc: linux-kernel@...r.kernel.org
Subject: Re: [PATCH] Replace the use of scnprintf() with sysfs_emit_at() in
 several show functions to format the output into the sysfs buffer.

On Sun, Jun 29, 2025 at 11:23:30PM +0530, herculoxz wrote:
> This change improves clarity and ensures proper bounds checking in
> line with the preferred sysfs_emit() API usage for sysfs 'show'
> functions. The PAGE_SIZE check is now handled internally by the helper.

Can you please a) add an 'mcb:' prefix to the subject and b) make it fit into
~75 chars?

Code wise it looks ok:

Reviewed-by: Johannes Thumshirn <jth@...nel.org>