linux-kernel - Re: [PATCH v6 05/23] mailbox: Allow controller specific mapping using fwnode

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAK9=C2WpN2_+wi-0AOZ_2xOK8z9oZk_dD__uRCu+E8iccjyC=Q@mail.gmail.com>
Date: Tue, 1 Jul 2025 12:20:18 +0530
From: Anup Patel <apatel@...tanamicro.com>
To: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
Cc: Michael Turquette <mturquette@...libre.com>, Stephen Boyd <sboyd@...nel.org>, 
	Rob Herring <robh@...nel.org>, Krzysztof Kozlowski <krzk+dt@...nel.org>, Conor Dooley <conor+dt@...nel.org>, 
	Jassi Brar <jassisinghbrar@...il.com>, Thomas Gleixner <tglx@...utronix.de>, 
	"Rafael J . Wysocki" <rafael@...nel.org>, Mika Westerberg <mika.westerberg@...ux.intel.com>, 
	Linus Walleij <linus.walleij@...aro.org>, Bartosz Golaszewski <brgl@...ev.pl>, 
	Uwe Kleine-König <ukleinek@...nel.org>, 
	Palmer Dabbelt <palmer@...belt.com>, Paul Walmsley <paul.walmsley@...ive.com>, 
	Len Brown <lenb@...nel.org>, Sunil V L <sunilvl@...tanamicro.com>, 
	Rahul Pathak <rpathak@...tanamicro.com>, Leyfoon Tan <leyfoon.tan@...rfivetech.com>, 
	Atish Patra <atish.patra@...ux.dev>, Andrew Jones <ajones@...tanamicro.com>, 
	Samuel Holland <samuel.holland@...ive.com>, Anup Patel <anup@...infault.org>, 
	linux-clk@...r.kernel.org, devicetree@...r.kernel.org, 
	linux-riscv@...ts.infradead.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v6 05/23] mailbox: Allow controller specific mapping using fwnode

On Mon, Jun 23, 2025 at 2:15 PM Andy Shevchenko
<andriy.shevchenko@...ux.intel.com> wrote:
>
> On Wed, Jun 18, 2025 at 05:43:40PM +0530, Anup Patel wrote:
> > Introduce optional fw_node() callback which allows a mailbox controller
> > driver to provide controller specific mapping using fwnode.
> >
> > The Linux OF framework already implements fwnode operations for the
> > Linux DD framework so the fw_xlate() callback works fine with device
> > tree as well.
>
> ...
>
> > +     fwnode = dev_fwnode(dev);
> > +     if (!fwnode) {
> > +             dev_dbg(dev, "No owner fwnode\n");
> > +             return ERR_PTR(-ENODEV);
> > +     }
> > +
> > +     ret = fwnode_property_get_reference_args(dev_fwnode(dev), "mboxes",
>
> Why not using fwnode directly here?

Argh, I missed replacing dev_fwnode() over here. Thanks for catching it,
I will update in the next revision.

>
> > +                                              "#mbox-cells", 0, index, &fwspec);
> >       if (ret) {
> > -             dev_err(dev, "%s: can't parse \"mboxes\" property\n", __func__);
> > +             dev_err(dev, "%s: can't parse \"%s\" property\n", __func__, "mboxes");
> >               return ERR_PTR(ret);
> >       }
>
> ...
>
> Otherwise looks like a good solution to get rid of OF-centric code from mailbox
> in the future.
>
> --
> With Best Regards,
> Andy Shevchenko
>
>

Thanks,
Anup