linux-kernel - Re: [PATCH v2 0/2] hwmon: (pmbus) Add support for MPS mp2869a/mp29612a controllers

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAL3H=v01Y6XBpkZDZT6qZeqDm4PR6uCaOGKYU=_z00a3ux8HgA@mail.gmail.com>
Date: Tue, 1 Jul 2025 16:04:31 +0800
From: Henry Wu <tzuhao.wtmh@...il.com>
To: Krzysztof Kozlowski <krzk@...nel.org>
Cc: Rob Herring <robh@...nel.org>, Krzysztof Kozlowski <krzk+dt@...nel.org>, 
	Conor Dooley <conor+dt@...nel.org>, Jean Delvare <jdelvare@...e.com>, 
	Guenter Roeck <linux@...ck-us.net>, Jonathan Corbet <corbet@....net>, 
	Jonathan Cameron <Jonathan.Cameron@...wei.com>, Fabio Estevam <festevam@...il.com>, 
	Naresh Solanki <naresh.solanki@...ements.com>, Rodrigo Gobbi <rodrigo.gobbi.7@...il.com>, 
	Michal Simek <michal.simek@....com>, Henry Wu <Henry_Wu@...ntatw.com>, 
	Grant Peltier <grantpeltier93@...il.com>, 
	Laurent Pinchart <laurent.pinchart@...asonboard.com>, 
	Cedric Encarnacion <cedricjustine.encarnacion@...log.com>, 
	John Erasmus Mari Geronimo <johnerasmusmari.geronimo@...log.com>, Jerome Brunet <jbrunet@...libre.com>, 
	Ninad Palsule <ninad@...ux.ibm.com>, Leo Yang <leo.yang.sy0@...il.com>, 
	Kim Seer Paller <kimseer.paller@...log.com>, Mariel Tinaco <Mariel.Tinaco@...log.com>, 
	Nuno Sa <nuno.sa@...log.com>, Thomas Weißschuh <linux@...ssschuh.net>, 
	Alex Vdovydchenko <xzeol@...oo.com>, devicetree@...r.kernel.org, linux-kernel@...r.kernel.org, 
	linux-hwmon@...r.kernel.org, linux-doc@...r.kernel.org, 
	peteryin.openbmc@...il.com
Subject: Re: [PATCH v2 0/2] hwmon: (pmbus) Add support for MPS
 mp2869a/mp29612a controllers

Krzysztof Kozlowski <krzk@...nel.org> 於 2025年6月30日 週一 下午7:29寫道：
>
> On 30/06/2025 13:20, tzuhao.wtmh@...il.com wrote:
> > From: Henry Wu <Henry_Wu@...ntatw.com>
> >
> > Add support for the mp2869a and mp29612a controllers from Monolithic Power
> > Systems, Inc. (MPS). These are dual-loop, digital, multi-phase modulation
> > controllers.
> >
> > ---
> >
> > Changes in v2:
> > - Fix coding style issues.
>
> Which ones? How?

I used checkpatch.pl with the "--strict" option and made the following
adjustments:
- Removed illegal spaces
- Converted comments to block style using /** ... */ instead of //
- Applied lowercase formatting to function names
Would you like me to list all the changes here, or should I include
them in the next patch?

>
> > - Using the pointer to replace the memcpy.
> > - Fix wrong device tree entries.
>
> What exactly? How did you fix it? I see zero changes. Your changelog
> should be specific, not vague.
In patch v1, I placed the mp2869a entry in the wrong order in
trivial-devices.yaml. In patch v2, I reordered it based on the
numerical order in the device name
>
>
> Best regards,
> Krzysztof

Best regards,
Henry Wu