linux-kernel - Re: [PATCH v4 02/10] mei: late_bind: add late binding component driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <a0e54703-721e-4e87-9962-7007771f947b@intel.com>
Date: Tue, 1 Jul 2025 13:37:36 +0530
From: "Nilawar, Badal" <badal.nilawar@...el.com>
To: Greg KH <gregkh@...uxfoundation.org>
CC: <intel-xe@...ts.freedesktop.org>, <dri-devel@...ts.freedesktop.org>,
	<linux-kernel@...r.kernel.org>, <anshuman.gupta@...el.com>,
	<rodrigo.vivi@...el.com>, <alexander.usyskin@...el.com>,
	<daniele.ceraolospurio@...el.com>
Subject: Re: [PATCH v4 02/10] mei: late_bind: add late binding component
 driver


On 28-06-2025 17:49, Greg KH wrote:
> On Wed, Jun 25, 2025 at 10:30:07PM +0530, Badal Nilawar wrote:
>> +/**
>> + * struct late_bind_component_ops - ops for Late Binding services.
>> + * @owner: Module providing the ops
>> + * @push_config: Sends a config to FW.
>> + */
>> +struct late_bind_component_ops {
>> +	struct module *owner;
> I don't think you ever set this field, so why is it here?
>
> Or did I miss it somewhere?

It is set in drivers/misc/mei/late_bind/mei_late_bind.c

static const struct late_bind_component_ops mei_late_bind_ops = {
         .owner = THIS_MODULE,
         .push_config = mei_late_bind_push_config,
};

Thanks,
Badal

>
> thanks,
>
> greg k-h