linux-kernel - Re: [PATCH staging] staging: rtl8723bs: replace magic numbers in rtl8723b

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <2025070110-unroll-hurried-ac37@gregkh>
Date: Tue, 1 Jul 2025 10:16:21 +0200
From: Greg KH <gregkh@...uxfoundation.org>
To: Marcos Garcia <magazo2005@...il.com>
Cc: philipp.g.hortmann@...il.com, dan.carpenter@...aro.org,
	karanja99erick@...il.com, rodrigo.gobbi.7@...il.com,
	linux-staging@...ts.linux.dev, linux-kernel@...r.kernel.org
Subject: Re: [PATCH staging] staging: rtl8723bs: replace magic numbers in
 rtl8723b_InitBeaconParameters()

On Tue, Jul 01, 2025 at 10:02:54AM +0200, Greg KH wrote:
> On Tue, Jul 01, 2025 at 09:40:49AM +0200, Marcos Garcia wrote:
> > 
> > 
> > Replace hardcoded values in rtl8723b_InitBeaconParameters() with defined constants
> > TBTT_PROHIBIT_VENDOR_DEFAULT (0x6404) and BCNTCFG_AIFS_MAX (0x660F) for clarity and
> > maintainability, addressing the TODO comment in the code.
> > 
> > The values were sourced from the following documentation:
> > - REG_TBTT_PROHIBIT (Offset 0x0540): Bits [15:8] = 0x64 (100ms prohibit time, 1ms units),
> >   Bits [7:0] = 0x04 (2ms margin, 0.5ms units), as per RTL8723BS Datasheet v1.5,
> >   Section 7.3.1.5 and RTL8723BS Programming Guide, p. 112.
> > - REG_BCNTCFG (Offset 0x0510): 0x660F sets max AIFS (0x0F) to prioritize beacon
> >   transmission, as per RTL8723BS Datasheet v1.5, Section 7.3.1.3.
> > 
> > Hi Dan,
> > 
> > Thank you for your detailed feedback — I truly appreciate it. I tried to contact you
> > earlier, but it seems my email didn't reach you. This is my first kernel contribution,
> > and I started by addressing TODO comments, thinking they were straightforward. I now
> > realize even these changes require deep hardware understanding. I used AI to assist with
> > parts of the commit message, but I didn't review it thoroughly enough, and I take full
> > responsibility for the vague comments. I could only find limited references to these
> > values, and the documentation seems restricted. I apologize for any oversight and
> > promise to research more carefully in the future. Thank you for your guidance.
> 
> None of this needs to be in the changelog text, please read the
> documentation for how to properly submit patches, especially second
> version of patches.

Make that the third version of this patch.