linux-kernel - RE: [PATCH v4 02/10] mei: late_bind: add late binding component driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CY5PR11MB6366894B5667A90759A7EADDED41A@CY5PR11MB6366.namprd11.prod.outlook.com>
Date: Tue, 1 Jul 2025 08:32:21 +0000
From: "Usyskin, Alexander" <alexander.usyskin@...el.com>
To: "Nilawar, Badal" <badal.nilawar@...el.com>, Greg KH
	<gregkh@...uxfoundation.org>
CC: "intel-xe@...ts.freedesktop.org" <intel-xe@...ts.freedesktop.org>,
	"dri-devel@...ts.freedesktop.org" <dri-devel@...ts.freedesktop.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>, "Gupta,
 Anshuman" <anshuman.gupta@...el.com>, "Vivi, Rodrigo"
	<rodrigo.vivi@...el.com>, "Ceraolo Spurio, Daniele"
	<daniele.ceraolospurio@...el.com>
Subject: RE: [PATCH v4 02/10] mei: late_bind: add late binding component
 driver

> > Subject: Re: [PATCH v4 02/10] mei: late_bind: add late binding component
> > driver
> >
> > On Tue, Jul 01, 2025 at 01:37:36PM +0530, Nilawar, Badal wrote:
> > >
> > > On 28-06-2025 17:49, Greg KH wrote:
> > > > On Wed, Jun 25, 2025 at 10:30:07PM +0530, Badal Nilawar wrote:
> > > > > +/**
> > > > > + * struct late_bind_component_ops - ops for Late Binding services.
> > > > > + * @owner: Module providing the ops
> > > > > + * @push_config: Sends a config to FW.
> > > > > + */
> > > > > +struct late_bind_component_ops {
> > > > > +	struct module *owner;
> > > > I don't think you ever set this field, so why is it here?
> > > >
> > > > Or did I miss it somewhere?
> > >
> > > It is set in drivers/misc/mei/late_bind/mei_late_bind.c
> > >
> > > static const struct late_bind_component_ops mei_late_bind_ops = {
> > >         .owner = THIS_MODULE,
> > >         .push_config = mei_late_bind_push_config, };
> >
> > Ah.  But then who uses it?  And why?  Normally forcing callers to set .owner
> is
> > frowned apon, use a #define correctly to have it automatically set for you in
> > the registration function please.
> >
> > And are you _sure_ you need it?
> 
> In xe kmd only uses .push_config so .owner can be dropped. Looks like it got
> propagated from previously implemented mei components but for none of
> the component .owner is used.  So it's fine to drop it.
> @Usyskin, Alexander please share your thoughts on this.
> 

As caller do not need this, can be dropped.

- - 
Thanks,
Sasha



> Badal
> 
> >
> > thanks,
> >
> > greg k-h